Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6992 getText update and getName fix #7047

Merged
merged 8 commits into from
May 24, 2024
Merged

6992 getText update and getName fix #7047

merged 8 commits into from
May 24, 2024

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented May 17, 2024

Description

#6992

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented May 17, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 625.57 kB → 625.72 kB (+155 B) +0.02%
Changeset
File Δ Size
../web3-eth-ens/lib/commonjs/resolver.js 📈 +167 B (+2.60%) 6.26 kB → 6.42 kB
../web3-eth-ens/lib/commonjs/ens.js 📈 +287 B (+2.52%) 11.12 kB → 11.4 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 606.28 kB → 606.43 kB (+155 B) +0.02%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 8f645ae Previous: 692987a Ratio
processingTx 9432 ops/sec (±3.65%) 8880 ops/sec (±3.76%) 0.94
processingContractDeploy 39880 ops/sec (±10.08%) 38813 ops/sec (±6.13%) 0.97
processingContractMethodSend 20539 ops/sec (±4.46%) 18943 ops/sec (±7.10%) 0.92
processingContractMethodCall 40979 ops/sec (±5.92%) 38006 ops/sec (±5.78%) 0.93
abiEncode 44981 ops/sec (±7.83%) 43737 ops/sec (±6.49%) 0.97
abiDecode 30812 ops/sec (±7.79%) 29525 ops/sec (±8.05%) 0.96
sign 1648 ops/sec (±0.66%) 1523 ops/sec (±3.37%) 0.92
verify 378 ops/sec (±0.43%) 371 ops/sec (±0.54%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@luu-alex
Copy link
Contributor

a mainnet test looking up these functions would be great

@jdevcs
Copy link
Contributor Author

jdevcs commented May 24, 2024

a mainnet test looking up these functions would be great

I tested some mainnet lookups locally, in some next PR after Infura rate limit fix we can add that.

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 92.20%. Comparing base (692987a) to head (8f645ae).

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7047      +/-   ##
==========================================
- Coverage   92.21%   92.20%   -0.02%     
==========================================
  Files         215      215              
  Lines        8329     8334       +5     
  Branches     2296     2300       +4     
==========================================
+ Hits         7681     7684       +3     
- Misses        648      650       +2     
Flag Coverage Δ
UnitTests 92.20% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@jdevcs jdevcs merged commit 962b99f into 4.x May 24, 2024
53 of 54 checks passed
@jdevcs jdevcs deleted the junaid/ensbugfix branch May 24, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants