fix(#7044): toWei trim strings with more than 20 decimal places #7045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordon-to
requested review from
avkos,
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
|
fixes #7044 |
jdevcs
reviewed
May 17, 2024
| let parsedNumber = number; | ||
| if (typeof parsedNumber === 'number'){ | ||
| if (parsedNumber < 1e-15){ | ||
| let parsedNumber: string; |
There was a problem hiding this comment.
@gordon-to thanks for PR,
due to this change , there are build errors:
Error: web3-utils: src/converters.ts(580,10): error TS2454: Variable 'parsedNumber' is used before being assigned.
Error: web3-utils: src/converters.ts(580,92): error TS24[54](https://github.com/web3/web3.js/actions/runs/9125740835/job/25095746688?pr=7045#step:6:55): Variable 'parsedNumber' is used before being assigned.
884fa09
to
1be5117
Compare
|
hey there, the PR is failing some of the testcases, in the |
gordon-to
force-pushed
the
fix-large-decimals-to-wei
branch
from
1be5117
to
6b6fe78
Compare
|
I added more tests and also added a fix for the function |
jdevcs
approved these changes
May 21, 2024
gordon-to
force-pushed
the
fix-large-decimals-to-wei
branch
from
29626e5
to
46b1acc
Compare
avkos
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.