Always have move event listener logic in MoveNodeToNewDocument() #46368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5546684
branch
3 times, most recently
from
c111974
to
bcbcb1a
Compare
This CL removes the check on moving event listeners from the fast adoption code, and adds it back to the common path. Bug: 341104769 Change-Id: Ic9738d9af97fecdcff6c8c45eea0634b6dc3b9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546684 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1304811}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5546684
branch
from
bcbcb1a
to
bb5f467
Compare
wpt-pr-bot
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL removes the check on moving event listeners from the fast
adoption code, and adds it back to the common path.
Bug: 341104769
Change-Id: Ic9738d9af97fecdcff6c8c45eea0634b6dc3b9dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546684
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304811}