[RWI] Change IdentityRequestProvider#request parameter to be an object #46361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5546326
branch
3 times, most recently
from
bea4944
to
216064a
Compare
This CL changes the real-world-identity API IdentityRequestProvider#request parameter to be either an object or a string. This brings the implementation in line with the spec https://wicg.github.io/digital-credentials/ BUG=341316049 Change-Id: I24011854918f30c552bf80ec7de86b6e2d64b9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546326 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Nicolás Peña <npm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306476}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5546326
branch
from
216064a
to
d4c9399
Compare
wpt-pr-bot
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL changes the real-world-identity API
IdentityRequestProvider#request parameter to be either an object or a
string. This brings the implementation in line with the spec
https://wicg.github.io/digital-credentials/
BUG=341316049
Change-Id: I24011854918f30c552bf80ec7de86b6e2d64b9db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546326
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1306476}