Fix up bugs in popover-light-dismiss-scroll-within.html. #46360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was extracted in [1] from the popover-light-dismiss.html test. But one `6` was missed in the style block, which broke it. [1] https://bugs.webkit.org/show_bug.cgi?id=273141 Fixed: 338339789 Change-Id: I0a1ae673187cc870dc1856981fc887058a765f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5549043 Reviewed-by: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1303406}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5549043
branch
from
e144263
to
ae5f0e2
Compare
wpt-pr-bot
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was extracted in [1] from the popover-light-dismiss.html
test. But one
6was missed in the style block, which broke it.[1] https://bugs.webkit.org/show_bug.cgi?id=273141
Fixed: 338339789
Change-Id: I0a1ae673187cc870dc1856981fc887058a765f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5549043
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1303406}