Update enablement approach for sec-ch-width tests #46359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5548997
branch
from
97e4eaf
to
b01527d
Compare
There are some higher-level interop/spec issues with how to enable sec-ch-width. This patch switches the tests to use name="Delegate-CH", which is per-spec [1], as well as sending the Accept-CH header. [1] https://wicg.github.io/client-hints-infrastructure/#delegate-ch-algo Bug: 335630145 Change-Id: Id37303bce2fb73c85505262cc5543e23701bd091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548997 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by: Traian Captan <tcaptan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1303438}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5548997
branch
from
b01527d
to
859410f
Compare
wpt-pr-bot
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some higher-level interop/spec issues with how to enable
sec-ch-width. This patch switches the tests to use name="Delegate-CH",
which is per-spec [1], as well as sending the Accept-CH header.
[1] https://wicg.github.io/client-hints-infrastructure/#delegate-ch-algo
Bug: 335630145
Change-Id: Id37303bce2fb73c85505262cc5543e23701bd091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548997
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1303438}