Add invalidation to select:open when datalist popover toggles #46356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5545431
branch
2 times, most recently
from
0b7c548
to
8a289b0
Compare
This patch makes select:open selectors get updated when the select is toggled open or closed due to popover triggering code. Without this, appearance:base-select <select>s might have styles applies for the closed state when they are open or vice versa. Bug: 40146374 Change-Id: If955675abf45a059f23cd005111152e72e1e5cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545431 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1303858}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5545431
branch
from
8a289b0
to
089ad58
Compare
wpt-pr-bot
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes select:open selectors get updated when the select is
toggled open or closed due to popover triggering code. Without this,
appearance:base-select <select>s might have styles applies for the
closed state when they are open or vice versa.
Bug: 40146374
Change-Id: If955675abf45a059f23cd005111152e72e1e5cda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545431
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1303858}