-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move some scrollend subtests to test variants.
Tests is scrollend-event-fired-for-programmatic-scroll.html execute several subtests in a single promise_test call. This can make debugging a intermittent failure a bit more difficult. Move the subtests to test variants to hopefully make debugging intermittent failures a bit easier. Differential Revision: https://phabricator.services.mozilla.com/D208406 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1835844 gecko-commit: 16b7bc7da3f82a38352aa97091f51b41caf89c3a gecko-reviewers: hiro
- Loading branch information
1 parent
2ad1106
commit 1218f7b
Showing
2 changed files
with
237 additions
and
76 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
147 changes: 147 additions & 0 deletions
147
dom/events/scrolling/scrollend-event-fired-for-scroll-attr-change.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| <!DOCTYPE HTML> | ||
| <meta name="viewport" content="width=device-width,initial-scale=1,minimum-scale=1"> | ||
| <script src="/resources/testharness.js"></script> | ||
| <script src="/resources/testharnessreport.js"></script> | ||
| <script src="/resources/testdriver.js"></script> | ||
| <script src="/resources/testdriver-actions.js"></script> | ||
| <script src="/resources/testdriver-vendor.js"></script> | ||
| <script src="/common/subset-tests-by-key.js"></script> | ||
| <meta name="variant" content="?include=subframe-scrollTop-smooth"/> | ||
| <meta name="variant" content="?include=subframe-scrollLeft-smooth"/> | ||
| <meta name="variant" content="?include=root-scrollTop-smooth"/> | ||
| <meta name="variant" content="?include=root-scrollLeft-smooth"/> | ||
| <meta name="variant" content="?include=subframe-scrollTop-auto"/> | ||
| <meta name="variant" content="?include=subframe-scrollLeft-auto"/> | ||
| <meta name="variant" content="?include=root-scrollTop-auto"/> | ||
| <meta name="variant" content="?include=root-scrollLeft-auto"/> | ||
| <script src="scroll_support.js"></script> | ||
| <style> | ||
| html { | ||
| height: 3000px; | ||
| width: 3000px; | ||
| } | ||
| #targetDiv { | ||
| width: 200px; | ||
| height: 200px; | ||
| overflow: scroll; | ||
| } | ||
|
|
||
| #innerDiv { | ||
| width: 400px; | ||
| height: 400px; | ||
| } | ||
| </style> | ||
|
|
||
| <body style="margin:0" onload=runTest()> | ||
| <div id="targetDiv"> | ||
| <div id="innerDiv"> | ||
| </div> | ||
| </div> | ||
| </body> | ||
| <script> | ||
| var element_scrollend_arrived = false; | ||
| var document_scrollend_arrived = false; | ||
|
|
||
| function onElementScrollEnd(event) { | ||
| assert_false(event.cancelable); | ||
| assert_false(event.bubbles); | ||
| element_scrollend_arrived = true; | ||
| } | ||
|
|
||
| function onDocumentScrollEnd(event) { | ||
| assert_false(event.cancelable); | ||
| // scrollend events are bubbled when the target node is document. | ||
| assert_true(event.bubbles); | ||
| document_scrollend_arrived = true; | ||
| } | ||
|
|
||
| let scroll_attr_change_variants = [ | ||
| { | ||
| key: "subframe-scrollTop-smooth", | ||
| target: targetDiv, | ||
| behavior: "smooth", | ||
| attribute: "scrollTop", | ||
| title: "Tests scrollend event for [scrollTop] behavior:'smooth' on subframe." | ||
| }, | ||
| { | ||
| key: "subframe-scrollLeft-smooth", | ||
| target: targetDiv, | ||
| behavior: "smooth", | ||
| attribute: "scrollLeft", | ||
| title: "Tests scrollend event for [scrollLeft] behavior:'smooth' on subframe." | ||
| }, | ||
| { | ||
| key: "root-scrollTop-smooth", | ||
| target: document.scrollingElement, | ||
| behavior: "smooth", | ||
| attribute: "scrollTop", | ||
| title: "Tests scrollend event for [scrollTop] behavior:'smooth' on root." | ||
| }, | ||
| { | ||
| key: "root-scrollLeft-smooth", | ||
| target: document.scrollingElement, | ||
| behavior: "smooth", | ||
| attribute: "scrollLeft", | ||
| title: "Tests scrollend event for [scrollLeft] behavior:'smooth' on root." | ||
| }, | ||
| { | ||
| key: "subframe-scrollTop-auto", | ||
| target: targetDiv, | ||
| behavior: "auto", | ||
| attribute: "scrollTop", | ||
| title: "Tests scrollend event for [scrollTop] behavior:'auto' on subframe." | ||
| }, | ||
| { | ||
| key: "subframe-scrollLeft-auto", | ||
| target: targetDiv, | ||
| behavior: "auto", | ||
| attribute: "scrollLeft", | ||
| title: "Tests scrollend event for [scrollLeft] behavior:'auto' on subframe." | ||
| }, | ||
| { | ||
| key: "root-scrollTop-auto", | ||
| target: document.scrollingElement, | ||
| behavior: "auto", | ||
| attribute: "scrollTop", | ||
| title: "Tests scrollend event for [scrollTop] behavior:'auto' on root." | ||
| }, | ||
| { | ||
| key: "root-scrollLeft-auto", | ||
| target: document.scrollingElement, | ||
| behavior: "auto", | ||
| attribute: "scrollLeft", | ||
| title: "Tests scrollend event for [scrollLeft] behavior:'auto' on root." | ||
| }, | ||
| ]; | ||
|
|
||
| function runTest() { | ||
|
|
||
| async function testScrollAttrChange(testInfo, t) { | ||
| targetDiv.addEventListener("scrollend", onElementScrollEnd); | ||
| document.addEventListener("scrollend", onDocumentScrollEnd); | ||
|
|
||
| testInfo.target.style.scrollBehavior = testInfo.behavior; | ||
|
|
||
| await waitForCompositorCommit(); | ||
|
|
||
| testInfo.target[testInfo.attribute] = 200; | ||
|
|
||
| await waitFor(() => { | ||
| return element_scrollend_arrived || document_scrollend_arrived; | ||
| }, testInfo.target.tagName + "." + testInfo.attribute + " did not receive scrollend event."); | ||
|
|
||
| if (testInfo.target == document.scrollingElement) { | ||
| assert_false(element_scrollend_arrived); | ||
| } else { | ||
| assert_false(document_scrollend_arrived); | ||
| } | ||
| assert_equals(testInfo.target[testInfo.attribute], 200, | ||
| testInfo.target.tagName + "." + testInfo.attribute + " " + testInfo.behavior); | ||
| } | ||
|
|
||
| scroll_attr_change_variants.forEach((testInfo) => { | ||
| subsetTestByKey(testInfo.key, promise_test, | ||
| async (t) => testScrollAttrChange(testInfo, t), testInfo.title); | ||
| }) | ||
| } | ||
| </script> |