Feature: Add Include/Exclude Class regular expression matcher #4937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
/claim #2481
Never used bounty before, just for fun, thank you for building this nice project.
This PR aims to address issue #2481.
I think it is just a bad idea trying to guess whether users intend to use an exact match or a regular expression. So in order to distinguish the intention and give more flexibility on settings, whether we could change
include
list to a list of struct:This approach offers clarity in distinguishing between exact matches and regular expressions. However, it may increase verbosity.
or adding a new array:
{ "include_patterns": []{} }
This alternative maintains backward compatibility with existing APIs and reduces verbosity. This PR use the second approach, if the direction seems ok, i would update docs and examples accordingly, please let me know.
Review checklist