Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a yalc-using package #70

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

aleclarson
Copy link
Contributor

@aleclarson aleclarson commented Jan 2, 2019

During yalc publish, the local .yalc directory is now copied to the global store, but its files are excluded from the content hash. Finally, the local yalc.lock file is copied and hashed.

The relevant commit: a9263e0

(Probably wanta merge #66 first)

and upgrade "husky" to v1.3
As to avoid reading the installations file when no changes are required.
The `yalc publish` command now copies (but never hashes) the local
".yalc" directory to the global store.

Also, the "yalc.lock" file is always copied/hashed now.
@aleclarson
Copy link
Contributor Author

Note: If you used yalc link in a package, the published version of that package will not use the linked package, because yalc link doesn't affect the package.json file.

@aleclarson
Copy link
Contributor Author

We need to consider if yalc push should be cascading or not. For example, if I do yalc push and it updates another yalc-using package, should that package be pushed as well? I'd say we probably want to prompt the user for them to decide. 😄

@aleclarson
Copy link
Contributor Author

TODO: Skip copying .yalc/{name} directories that correspond to devDependencies.

@aleclarson
Copy link
Contributor Author

Another thing to consider:

Since node.js doesn't dedupe packages based on version, there's a good chance of having multiple "instances" of the same package when yalc is used extensively in a dependency tree. This can easily lead to confusing bugs.

We could prevent duplicate yalc-linked packages by hoisting them or by linking to the same .yalc directory for every yalc-using package; neither of which sounds particularly easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant