Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wasmer_config::package::PackageHash to be an enum #4715

Merged
merged 3 commits into from
May 21, 2024

Conversation

PappuPanaut
Copy link

Description

Code cleanup:
wasmer_config::package::PackageHash - Refactor to enum #4585

Copy link
Contributor

@maminrayej maminrayej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks reasonable to me.

lib/config/src/package/package_hash.rs Outdated Show resolved Hide resolved
@maminrayej maminrayej changed the title wasmer_config::package::PackageHash - Refactor to enum #4585 Refactor wasmer_config::package::PackageHash to be an enum May 17, 2024
@Arshia001
Copy link
Member

@PappuPanaut @maminrayej I assume merging main into the PR branch would fix the CI failure.

@maminrayej
Copy link
Contributor

I assume merging main into the PR branch would fix the CI failure.

Yes.

@syrusakbary syrusakbary merged commit ead660f into wasmerio:main May 21, 2024
60 of 61 checks passed
@maminrayej
Copy link
Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants