Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): allow users to add model_artifact_name and model_artifact_type in the OpenAI Fine-Tuning integration #7644

Merged
merged 9 commits into from
May 21, 2024

Conversation

luisbergua
Copy link
Contributor

@luisbergua luisbergua commented May 14, 2024

Description

What does the PR do? Include a concise description of the PR contents.

Allows users to set the model name and type for the OpenAI Fine-Tuning integration instead of automatically using "model-metadata" and "model"

Before:

WandbLogger.sync(fine_tune_job_id=ft_job_id, project=WANDB_PROJECT, openai_client=client)
image

After:

WandbLogger.sync(fine_tune_job_id=ft_job_id, project=WANDB_PROJECT, openai_client=client, model_artifact_name="new-model", model_artifact_type="my-type")
image
  • [ x] I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.84%. Comparing base (e649a26) to head (5773f38).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7644      +/-   ##
==========================================
+ Coverage   74.28%   75.84%   +1.55%     
==========================================
  Files         500      500              
  Lines       55727    54121    -1606     
==========================================
- Hits        41396    41047     -349     
+ Misses      13923    12666    -1257     
  Partials      408      408              
Flag Coverage Δ
func 41.34% <0.00%> (+0.02%) ⬆️
system 63.49% <0.00%> (ø)
unit 56.37% <0.00%> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/integration/openai/fine_tuning.py 0.00% <0.00%> (ø)

... and 102 files with indirect coverage changes

Copy link
Member

@morganmcg1 morganmcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luisbergua luisbergua changed the title feat(integrations): allow users to add model_name in the OpenAI Fine-Tuning integration feat(integrations): allow users to add model_name and model_type in the OpenAI Fine-Tuning integration May 21, 2024
@luisbergua luisbergua changed the title feat(integrations): allow users to add model_name and model_type in the OpenAI Fine-Tuning integration feat(integrations): allow users to add model_artifact_name and model_artifact_type in the OpenAI Fine-Tuning integration May 21, 2024
@luisbergua luisbergua merged commit defdd0d into main May 21, 2024
45 checks passed
@luisbergua luisbergua deleted the PB-39787434 branch May 21, 2024 15:18
luisbergua added a commit that referenced this pull request May 22, 2024
Co-authored-by: Katia Patkin <87335417+kptkin@users.noreply.github.com>
@luisbergua
Copy link
Contributor Author

Adding params description #7681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants