-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(artifacts): pipeline the artifact file uploader #7586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7586 +/- ##
==========================================
+ Coverage 74.26% 75.85% +1.58%
==========================================
Files 500 500
Lines 55732 54153 -1579
==========================================
- Hits 41392 41080 -312
+ Misses 13932 12663 -1269
- Partials 408 410 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
moredatarequired
force-pushed
the
pipeline-artifact-saver
branch
3 times, most recently
from
May 7, 2024 17:21
cb204c5
to
4b45057
Compare
moredatarequired
force-pushed
the
pipeline-artifact-saver
branch
from
May 7, 2024 19:33
4b45057
to
c7788db
Compare
kptkin
reviewed
May 9, 2024
moredatarequired
force-pushed
the
pipeline-artifact-saver
branch
from
May 13, 2024 21:25
c7788db
to
fe82c52
Compare
jlzhao27
reviewed
May 13, 2024
moredatarequired
force-pushed
the
pipeline-artifact-saver
branch
from
May 14, 2024 20:45
fe82c52
to
28d430e
Compare
moredatarequired
force-pushed
the
pipeline-artifact-saver
branch
2 times, most recently
from
May 15, 2024 00:30
cac9d37
to
80e086f
Compare
jlzhao27
approved these changes
May 15, 2024
jlzhao27
reviewed
May 15, 2024
jlzhao27
reviewed
May 15, 2024
jlzhao27
reviewed
May 15, 2024
jlzhao27
reviewed
May 15, 2024
moredatarequired
force-pushed
the
pipeline-artifact-saver
branch
from
May 16, 2024 19:00
80e086f
to
597d472
Compare
tonyyli-wandb
approved these changes
May 17, 2024
moredatarequired
force-pushed
the
pipeline-artifact-saver
branch
from
May 17, 2024 21:59
d94f93c
to
9b47788
Compare
kptkin
approved these changes
May 21, 2024
moredatarequired
force-pushed
the
pipeline-artifact-saver
branch
from
May 21, 2024 17:58
9b47788
to
e4b8b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrite of
ArtifactSaver.uploadFiles
to use buffered channels and switch between available pending tasksThis is an alternative to #7274, and should be considered to supersede it. It's dramatically simpler, has similar (though slightly lower) performance, and handles retries better.
Key differences:
Minor differences:
Differences:
time.Ticker
channel in the futureData flow:
Assemble batches
While not done:
If files fail to upload, collect them to retry. Retry all failed uploads by rerunning the above as long as each time we succeed for at least half the files.
Testing
Very extensively tested for performance (on extremely large artifacts).
Relies somewhat heavily on existing integration tests in CI for correctness.