server: process wait conditions in batch mode #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brig
force-pushed
the
brig/wait-conditions-batch
branch
2 times, most recently
from
6999b84
to
b3d8c73
Compare
brig
changed the title
brig
force-pushed
the
brig/wait-conditions-batch
branch
from
b3d8c73
to
8a2282d
Compare
ibodrov
reviewed
May 20, 2024
| ProcessQueue q = PROCESS_QUEUE.as("q"); | ||
| return tx.select(q.INSTANCE_ID, q.CURRENT_STATUS) | ||
| .from(q) | ||
| .where(q.INSTANCE_ID.in(processes)) |
There was a problem hiding this comment.
Is JOOQ smart enough to turn this INSTANCE_ID IN (...) into an array operation? I'm worried that it's going to fail for large processes sets.
There was a problem hiding this comment.
There was a problem hiding this comment.
So the upper limit is waitProcessLimitForStatusQuery? Should be fine, I think, but for the query parser sake I'd replaced with an array operation if it is possible here.
There was a problem hiding this comment.
yes, waitProcessLimitForStatusQuery is a limit
ibodrov
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the idea here is this: instead of processing each wait condition individually, we will process them in batches. As a result, instead of requesting the status for each process separately, we will request the statuses for a batch of processes at once