runtime-v1, runtime-v2: Capture docker output in separate threads. #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
DockerServiceimplementations capture docker process output streams (stdoutandstderr) in the same thread one after the other.stderrdoesn't have to be very large before everything hangs indefinitely (process timeout limit will fail the process and clean it up eventually). This happens on arg configs that capture separate streams. If no output is captured it works because service redirects the streams to a single output stream.Now, when then is fixed...it will allow more log output since nothing hangs/crashes. We may need some "max docker capture size" restriction so we don't run out of memory holding onto output streams in variables returned to the process.