Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secrets: single value secret update example #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

secrets: single value secret update example #93

wants to merge 2 commits into from

Conversation

brig
Copy link
Contributor

@brig brig commented Aug 31, 2021

No description provided.

@brig brig requested a review from a team August 31, 2021 15:22
ibodrov
ibodrov reviewed Aug 31, 2021
View reviewed changes
docs/api/secret.md Outdated Show resolved Hide resolved
rodrigc
rodrigc reviewed Sep 8, 2021
View reviewed changes
docs/api/secret.md
@@ -198,6 +199,19 @@ Updates parameters of an existing secret.
}
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK. Since you are giving instructions for how to update from the command-line,
I suggest that you extend this example slightly, by using the base64 command line utility to encode the secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibodrov ibodrov ibodrov left review comments

@rodrigc rodrigc rodrigc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brig @ibodrov @rodrigc