Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing hyphens in Loops example. #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Skitbra
Copy link

@Skitbra Skitbra commented Oct 15, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2020

CLA assistant check
All committers have signed the CLA.

@@ -458,8 +458,8 @@ flows:
in:
msg: "${item.key} - ${item.value}"
withItems:
a: "Hello"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the withItems part is correct in this example. It is using withItems with a dict (Map) object. It iterates over the objects keys and is an equivalent of

"withItems": {
  "a": "Hello",
  "b": "world"
}

Example output:

> cat concord.yml
flows:
  default:
    - task: log
      in:
        msg: "${item.key} - ${item.value}"
      withItems:
        a: "Hello"
        b: "world"

> concord run
Starting...
13:14:15.308 [main] a - Hello
13:14:15.310 [main] b - world
...done!

Although we should change call: log to task: log to make the example runnable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Maybe you can change that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants