Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.android.tools.build:gradle from 8.3.2 to 8.4.0 #1397

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 1, 2024

Bumps com.android.tools.build:gradle from 8.3.2 to 8.4.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 1, 2024
@tcitworld
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/com.android.tools.build-gradle-8.4.0 branch from 166fcb0 to 5437ad2 Compare May 1, 2024 09:23
@tcitworld
Copy link
Member

tcitworld commented May 1, 2024

Needs a gradle wrapper update as well, do you mind taking take of that @Strubbl ?

@Strubbl
Copy link
Contributor

Strubbl commented May 1, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github May 1, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

dependabot bot and others added 2 commits May 1, 2024 16:21
Bumps com.android.tools.build:gradle from 8.3.2 to 8.4.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@Strubbl Strubbl force-pushed the dependabot/gradle/com.android.tools.build-gradle-8.4.0 branch from eabe5fe to 6ef8ed8 Compare May 1, 2024 14:21
@Strubbl Strubbl force-pushed the dependabot/gradle/com.android.tools.build-gradle-8.4.0 branch 2 times, most recently from b8f418c to 452444f Compare May 1, 2024 15:09
@Strubbl
Copy link
Contributor

Strubbl commented May 1, 2024

It looks like setting java toolchain to v21 was the solution. It was implicitly set to v8 (see warnings during build), but i do not know where or why

@tcitworld tcitworld merged commit e3f7a50 into master May 1, 2024
2 checks passed
@tcitworld tcitworld deleted the dependabot/gradle/com.android.tools.build-gradle-8.4.0 branch May 1, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants