-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scrolling after gocui update #473
base: main
Are you sure you want to change the base?
Conversation
Built using go1.21.0 and tested on Ubuntu 20.04. Unfortunately the scrolling bug is still there. :( |
Ah, I see I've only fixed it for the |
638f923
to
8cfa1a3
Compare
Yup. Scroll seems to work for me now. |
Would be great to see a new release with this fix, as it severely limits the usability of dive for nix-based images :) |
To run this branch
|
@wagoodman @mark2185 whats missing for this PR to get merged? Want to offer help 🤝 |
Seems like these lines need to be fixed in order to pass ci check runtime/ui/view/layer.go:298:14: Error return value of `v.vm.Update` is not checked (errcheck)
v.vm.Update(v.constrainedRealEstate)
^
runtime/ui/viewmodel/layer_set_state.go:42:26: func `(*LayerSetState).height` is unused (unused)
func (vm *LayerSetState) height() int {
^
runtime/ui/view/layer.go:153:17: func `(*Layer).height` is unused (unused)
func (v *Layer) height() uint {
^ |
Please release this - super annoying bug. |
I just had to rebase this PR on top of the current head ( 925cdd8 ) of Thanks for the patch! |
Any update? @wagoodman |
Would be great for this fix to reach the next release |
Sadly, the logs have expired already. |
You can still see what was the issue here. https://github.com/wagoodman/dive/actions/runs/6391362920?pr=473 I made another pull request based on this one here, #520, that should hopefully pass all the checks. I just need someone to review and approve it now. Will be nice if we can finally have this fix in new versions. |
This fixes the scrolling caused by a regression in #447 .
It still has some issues regarding highlighting rows, but I'm not overtly interested in diving into
gocui
given that it's not actively maintained. At least it enables the user to scroll again.