Merge release/v0.24.0 #4390
Merge release/v0.24.0 #4390
Conversation
…f classes or a dict mapping ids to labels
fix: coco category ids can now be not sequential - avoiding memory leak
Adding custom runs plugin and minor tweaks
DeepSort tracking enhancements
fix absolute css position for view bar icons
Add runs plugin to docs
* convert to timezone only if datetime is tzaware; add exposing test
* WIP 3D export fixes and tests * print * errant copypasta * move rewrite asset logic to scene_3d * cleanup 3d import/export tests a bit
Support non-sequential COCO category IDs
* add np casting to json encoder * isinstance * add test * add await
tweak zoom and workspace right alignment [v0.24.0]
* handle state payload in useRefresh * cleanup * skip e2e refresh * cleanup, comment
* fix multi pcd e2e * fix media visibility toggler e2e
WalkthroughThe updates encompass a wide array of enhancements and fixes across multiple components of the project. Key changes include modifications in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4390 +/- ##
===========================================
- Coverage 16.02% 16.00% -0.03%
===========================================
Files 804 807 +3
Lines 89221 89383 +162
Branches 1340 1342 +2
===========================================
+ Hits 14300 14308 +8
- Misses 74921 75075 +154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Out of diff range and nitpick comments (23)
fiftyone/operators/builtin.py (1)
Line range hint
53-53: Remove the unused variablesample_idsto clean up the code.- sample_ids = ctx.dataset.add_collection(samples, new_ids=True)fiftyone/zoo/datasets/__init__.py (2)
Line range hint
120-120: Avoid using bareexceptstatements.- except: + except Exception as e: + logger.error("Failed to load dataset info: %s", str(e))Using a bare
exceptcan catch unexpected exceptions, making debugging difficult. It's better to catch specific exceptions or at least log the error for better traceability.
Line range hint
577-577: Avoid using bareexceptstatements.- except: + except Exception as e: + logger.error("Failed to construct zoo dataset instance: %s", str(e))Similar to the previous comment, using a bare
exceptcan catch unexpected exceptions, which can obscure underlying issues. CatchingExceptionand logging the error provides more control and better error information.fiftyone/core/odm/database.py (6)
Line range hint
281-281: Replace bareexceptwith specific exceptions to avoid catching unexpected errors.- except: + except Exception as e: + # Handle or log the exception e
Line range hint
291-291: Replace bareexceptwith specific exceptions to avoid catching unexpected errors.- except: + except Exception as e: + # Handle or log the exception e
Line range hint
616-616: Replace bareexceptwith specific exceptions to avoid catching unexpected errors.- except: + except Exception as e: + # Handle or log the exception e
Line range hint
861-861: Replace bareexceptwith specific exceptions to avoid catching unexpected errors.- except: + except Exception as e: + # Handle or log the exception e
Line range hint
1020-1020: Replace bareexceptwith specific exceptions to avoid catching unexpected errors.- except: + except Exception as e: + # Handle or log the exception e
Line range hint
1163-1163: Replace bareexceptwith specific exceptions to avoid catching unexpected errors.- except: + except Exception as e: + # Handle or log the exception efiftyone/utils/coco.py (7)
Line range hint
605-605: Ambiguous variable name 'l' can be confusing. Consider renaming it to a more descriptive name.
Line range hint
1795-1795: Ambiguous variable name 'l' can be confusing. Consider renaming it to a more descriptive name.
Line range hint
1820-1820: Avoid equality comparisons toTrue; useif include_license:for truth checks.- if include_license == True: + if include_license:
Line range hint
1984-1984: Ambiguous variable name 'l' can be confusing. Consider renaming it to a more descriptive name.
Line range hint
2127-2127: Avoid equality comparisons toTrue; useif extra_attrs:for truth checks.- if extra_attrs == True: + if extra_attrs:
Line range hint
2130-2130: Avoid equality comparisons toFalse; useif not extra_attrs:for false checks.- if extra_attrs == False: + if not extra_attrs:
Line range hint
2252-2252: Do not use bareexcept. Specify the exception type to handle specific exceptions and avoid catching unexpected events.- except: + except SomeSpecificException:fiftyone/utils/data/exporters.py (7)
Line range hint
541-541: Replace bareexceptwith specific exception handling.- except: + except Exception:
Line range hint
571-571: Replace bareexceptwith specific exception handling.- except: + except Exception:
Line range hint
614-614: Replace bareexceptwith specific exception handling.- except: + except Exception:
Line range hint
649-649: Replace bareexceptwith specific exception handling.- except: + except Exception:
Line range hint
904-904: Replace bareexceptwith specific exception handling.- except: + except Exception:
Line range hint
3821-3821: Use direct truth checks instead of inequality comparisons toFalse.- if include_confidence == True: + if include_confidence:
Line range hint
3947-3947: Use direct truth checks instead of equality comparisons toTrue.- if include_confidence == True: + if include_confidence:
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (24)
- app/packages/app/src/useEvents/useRefresh.ts (1 hunks)
- app/packages/core/src/components/ImageContainerHeader.tsx (1 hunks)
- app/packages/core/src/components/ViewBar/ViewBar.tsx (1 hunks)
- app/packages/looker-3d/src/fo3d/Leva.tsx (1 hunks)
- app/packages/operators/src/built-in-operators.ts (2 hunks)
- app/packages/spaces/src/components/Workspaces/index.tsx (1 hunks)
- docs/source/plugins/index.rst (2 hunks)
- docs/source/user_guide/export_datasets.rst (1 hunks)
- e2e-pw/src/oss/poms/fo3d/assets-panel/index.ts (1 hunks)
- e2e-pw/src/oss/specs/groups/modal-multi-pcd.spec.ts (2 hunks)
- e2e-pw/src/oss/specs/smoke-tests/quickstart-groups.spec.ts (4 hunks)
- fiftyone/core/fields.py (1 hunks)
- fiftyone/core/odm/database.py (1 hunks)
- fiftyone/core/threed/scene_3d.py (1 hunks)
- fiftyone/operators/builtin.py (1 hunks)
- fiftyone/operators/operations.py (2 hunks)
- fiftyone/server/decorators.py (3 hunks)
- fiftyone/utils/coco.py (42 hunks)
- fiftyone/utils/data/exporters.py (3 hunks)
- fiftyone/utils/tracking/deepsort.py (2 hunks)
- fiftyone/zoo/datasets/init.py (1 hunks)
- tests/unittests/dataset_tests.py (2 hunks)
- tests/unittests/import_export_tests.py (3 hunks)
- tests/unittests/server_decorators_tests.py (1 hunks)
Files skipped from review due to trivial changes (4)
- app/packages/core/src/components/ImageContainerHeader.tsx
- app/packages/core/src/components/ViewBar/ViewBar.tsx
- app/packages/looker-3d/src/fo3d/Leva.tsx
- app/packages/spaces/src/components/Workspaces/index.tsx
Additional Context Used
Ruff (35)
fiftyone/core/odm/database.py (6)
281-281: Do not use bare
except
291-291: Do not use bare
except
616-616: Do not use bare
except
861-861: Do not use bare
except
1020-1020: Do not use bare
except
1163-1163: Do not use bare
exceptfiftyone/operators/builtin.py (1)
53-53: Local variable
sample_idsis assigned to but never usedfiftyone/utils/coco.py (8)
605-605: Ambiguous variable name:
l
917-917: Ambiguous variable name:
l
1795-1795: Ambiguous variable name:
l
1820-1820: Avoid equality comparisons to
True; useif include_license:for truth checks
1984-1984: Ambiguous variable name:
l
2127-2127: Avoid equality comparisons to
True; useif extra_attrs:for truth checks
2130-2130: Avoid equality comparisons to
False; useif not extra_attrs:for false checks
2252-2252: Do not use bare
exceptfiftyone/utils/data/exporters.py (9)
541-541: Do not use bare
except
571-571: Do not use bare
except
614-614: Do not use bare
except
649-649: Do not use bare
except
904-904: Do not use bare
except
3821-3821: Avoid inequality comparisons to
False; useif include_confidence:for truth checks
3821-3821: Avoid inequality comparisons to
False; useif include_attributes:for truth checks
3947-3947: Avoid equality comparisons to
True; useif include_confidence:for truth checks
3952-3952: Avoid equality comparisons to
True; useif include_attributes:for truth checksfiftyone/zoo/datasets/__init__.py (2)
120-120: Do not use bare
except
577-577: Do not use bare
excepttests/unittests/dataset_tests.py (3)
312-312: Local variable
viewis assigned to but never used
1305-1305: Do not assign a
lambdaexpression, use adef
1489-1489: Do not assign a
lambdaexpression, use adeftests/unittests/import_export_tests.py (6)
2162-2162:
pydicomimported but unused
3600-3600: Local variable
img_filepathis assigned to but never used
3617-3617: Local variable
img_filepathis assigned to but never used
3635-3635: Local variable
img_filepathis assigned to but never used
3664-3664: Local variable
img_filepathis assigned to but never used
3734-3734: Local variable
vid_filepathis assigned to but never used
Path-based Instructions (5)
e2e-pw/src/oss/poms/fo3d/assets-panel/index.ts (1)
Pattern
**/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.app/packages/app/src/useEvents/useRefresh.ts (1)
Pattern
**/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.e2e-pw/src/oss/specs/groups/modal-multi-pcd.spec.ts (1)
Pattern
**/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.e2e-pw/src/oss/specs/smoke-tests/quickstart-groups.spec.ts (1)
Pattern
**/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.app/packages/operators/src/built-in-operators.ts (1)
Pattern
**/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
Additional comments not posted (53)
e2e-pw/src/oss/poms/fo3d/assets-panel/index.ts (1)
12-35: Well-implemented method for dragging the 3D assets panel.The method
dragToToLeftCornercorrectly handles visibility checks, error scenarios, and performs the drag operation using calculated offsets. Good use of asynchronous operations and error handling.app/packages/app/src/useEvents/useRefresh.ts (1)
12-34: Proper use of React and Recoil patterns inuseRefreshhook.The
useRefreshhook correctly usesuseCallbackto memoize the refresh function, handles state processing, URL resolution, and navigation. It also properly manages subscriptions and state updates to trigger re-renders. Good adherence to React and Recoil best practices.fiftyone/server/decorators.py (1)
Line range hint
35-54: Well-implemented server utilities for response handling and routing.The
create_responsefunction androutedecorator are correctly implemented with comprehensive error handling, asynchronous operations, and custom JSON encoding for numpy types. Good use of modern Python features and best practices in web server development.e2e-pw/src/oss/specs/groups/modal-multi-pcd.spec.ts (1)
Line range hint
20-69: Effective end-to-end testing of modal interactions with PCD files.The test scenarios in
modal-multi-pcd.spec.tseffectively set up PCD files, add them to a dataset, and verify the modal's behavior when interacting with 3D slices. Good use of assertions to check UI states and proper handling of dynamic file paths in the setup.e2e-pw/src/oss/specs/smoke-tests/quickstart-groups.spec.ts (1)
Line range hint
17-106: Comprehensive smoke testing of UI interactions in "quickstart-groups".The smoke tests in
quickstart-groups.spec.tseffectively cover a range of UI interactions, including sample navigation, media visibility toggling, and group filtering. Good use of theAsset3dPanelPomfor adjusting UI elements and robust assertions to verify the UI states.fiftyone/utils/tracking/deepsort.py (1)
Line range hint
25-164: Robust implementation of object tracking withDeepSort.The
DeepSortclass provides well-implemented methods for setting up and performing object tracking in video streams. The methods are well-documented, handle errors gracefully, and use modern Python practices for handling video data and tracking logic.docs/source/plugins/index.rst (1)
Line range hint
1-114: Clear and informative documentation for the FiftyOne plugins framework.The documentation in
index.rsteffectively provides an overview of the FiftyOne plugins framework, detailing available plugins and their functionalities. The structure is clear, and the use of external links and tables enhances the readability and utility of the documentation.fiftyone/operators/operations.py (1)
320-333: Ensure proper handling ofspacesandnameparameters inset_spaces.fiftyone/core/threed/scene_3d.py (1)
262-300: Review the handling of asset paths inupdate_asset_pathsto ensure all paths are correctly updated.app/packages/operators/src/built-in-operators.ts (1)
775-782: Ensure that theLOAD_WORKSPACE_OPERATORis correctly used inSetSpacesand that error handling for missing parameters is robust.Verification successful
The search results confirm that the
LOAD_WORKSPACE_OPERATORis defined inapp/packages/spaces/src/components/Workspaces/constants.tsand is used in multiple files within the codebase, including thebuilt-in-operators.tsfile where it is used in theSetSpacesclass as described in the review comment. This indicates that the operator is implemented and utilized correctly in the context of theSetSpacesclass.Additionally, the error handling for missing parameters in the
SetSpacesclass, which throws an error if neitherspacesnornameis provided, appears to be robust and correctly implemented.Based on this information, the review comment concerning the correct usage of
LOAD_WORKSPACE_OPERATORand the error handling in theSetSpacesclass is verified as accurate.
- The
LOAD_WORKSPACE_OPERATORis correctly imported and used inapp/packages/operators/src/built-in-operators.ts.- The error handling for missing parameters in the
SetSpacesclass is implemented as expected.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `LOAD_WORKSPACE_OPERATOR` is correctly implemented and used. # Test: Search for the implementation and usage of `LOAD_WORKSPACE_OPERATOR`. Expect: Correct implementation and usage. rg --type typescript $'LOAD_WORKSPACE_OPERATOR'Length of output: 81
Script:
#!/bin/bash # Description: Re-verify the implementation and usage of `LOAD_WORKSPACE_OPERATOR` by searching in TypeScript files. # Adjusted Test: Search for the implementation and usage of `LOAD_WORKSPACE_OPERATOR` in `.ts` and `.tsx` files. Expect: Correct implementation and usage. rg 'LOAD_WORKSPACE_OPERATOR' --glob '*.ts' --glob '*.tsx'Length of output: 973
fiftyone/zoo/datasets/__init__.py (8)
Line range hint
35-71: Functionlist_zoo_datasetsimplementation looks good.The function effectively utilizes helper functions to filter datasets based on tags and sources. The logic is clear and well-documented.
Line range hint
73-95: Functionlist_downloaded_zoo_datasetsimplementation looks good.The function handles potential errors during directory listing and iterates over subdirectories to gather information about downloaded datasets. The error handling and logic are appropriate.
Line range hint
97-160: Functiondownload_zoo_datasetimplementation looks good.The function is complex but well-structured, using helper functions to parse dataset details and handle the download process. The documentation is thorough, and the function handles different scenarios like existing splits and overwrites effectively.
Line range hint
162-364: Functionload_zoo_datasetimplementation looks good.This function is well-documented and handles a variety of scenarios including downloading datasets if necessary, loading existing datasets, and managing data importers. The use of helper functions to extract arguments and manage dataset importers is effective and maintains code clarity.
Line range hint
366-402: Functionfind_zoo_datasetimplementation looks good.The function effectively finds the directory of a specified dataset and handles cases where the dataset or split is not downloaded. The error handling and use of helper functions to parse dataset details are appropriate.
Line range hint
404-424: Functionload_zoo_dataset_infoimplementation looks good.The function handles loading of dataset information effectively, including error handling for cases where the dataset is not downloaded. The use of helper functions to parse dataset details maintains code clarity.
Line range hint
426-450: Functionget_zoo_datasetimplementation looks good.The function retrieves a dataset instance and handles errors during construction effectively. The error handling and use of helper functions to retrieve the dataset class are appropriate.
Line range hint
452-474: Functiondelete_zoo_datasetimplementation looks good.The function effectively deletes a specified dataset or split from the local disk. It uses helper functions to find the dataset or split directory and updates the dataset information if a split is deleted.
fiftyone/core/fields.py (1)
519-526: The adjustments to ensure UTC timezone handling in theDateFieldclass are correctly implemented and follow best practices for timezone consistency.tests/unittests/import_export_tests.py (9)
4681-4684: The classThreeDMediaTestsis well-documented, providing a clear description of its purpose.
4686-4707: The method_build_flat_relativecorrectly constructs a dataset with relative paths. It properly handles the creation of assets and their addition to the dataset.
4709-4736: The method_build_flat_absoluteis implemented correctly, handling absolute paths for assets and ensuring they are written correctly.
4741-4800: The method_build_nested_relativeeffectively handles the creation of a nested dataset structure with relative paths. It ensures that assets are placed correctly in the nested directories.
4802-4808: The method_assert_scene_contentcorrectly asserts the content of the scene files, ensuring that the read content matches the expected filenames.
4811-4834: The methodtest_flat_relativeeffectively tests the export functionality for a flat dataset with relative paths, ensuring that all files are exported correctly and that the scene content remains consistent.
4836-4865: The methodtest_flat_absolutecorrectly tests the export functionality for a flat dataset with absolute paths, ensuring that all files are exported correctly and that the scene content remains consistent.
4867-4942: The methodtest_relative_nested_flatteneffectively tests the export functionality for a nested dataset with relative paths, ensuring that the structure is flattened during export and that duplicate filenames are handled correctly.
4943-4984: The methodtest_relative_nested_maintaincorrectly tests the export functionality for maintaining the nested directory structure during export, ensuring that the relative paths in the.fo3dfiles are preserved and that the file contents are correct.tests/unittests/dataset_tests.py (25)
Line range hint
29-48: The implementation oftest_list_datasetslooks good and covers the expected functionality effectively.
Line range hint
50-84: The implementation oftest_dataset_namescorrectly tests dataset naming and slug functionalities.
Line range hint
86-112: The implementation oftest_delete_datasetcorrectly tests the dataset deletion functionality.
Line range hint
114-120: The implementation oftest_backing_doc_classcorrectly tests the backing document class functionality.
Line range hint
122-138: The implementation oftest_eqcorrectly tests the equality of dataset instances.
Line range hint
140-156: The implementation oftest_last_loaded_atcorrectly tests the updating of thelast_loaded_atattribute.
Line range hint
158-182: The implementation oftest_dataset_tagscorrectly tests the handling of dataset tags.
Line range hint
184-196: The implementation oftest_dataset_descriptioncorrectly tests the handling of the description attribute.
Line range hint
198-216: The implementation oftest_dataset_infocorrectly tests the handling of the info attribute.
Line range hint
218-286: The implementation oftest_dataset_field_metadatacorrectly tests the handling of field metadata.
Line range hint
288-324: The implementation oftest_dataset_app_configcorrectly tests the handling of the app configuration.
Line range hint
326-352: The implementation oftest_meta_datasetcorrectly tests various operations on a meta dataset.
Line range hint
354-394: The implementation oftest_indexescorrectly tests the handling of indexes in a dataset.
Line range hint
396-418: The implementation oftest_iter_samplescorrectly tests the iteration over samples in a dataset.
Line range hint
420-577: The implementation oftest_date_fieldscorrectly tests the handling of date fields in a dataset, including timezone changes.
Line range hint
579-606: The implementation oftest_datetime_fieldscorrectly tests the handling of datetime fields in a dataset, including timezone conversions.
Line range hint
608-688: The implementation oftest_get_fieldcorrectly tests the retrieval of various types of fields from a dataset.
Line range hint
690-770: The implementation oftest_get_field_framescorrectly tests the retrieval of various types of frame fields from a dataset.
Line range hint
772-792: The implementation oftest_field_namescorrectly tests the naming rules for fields in a dataset.
Line range hint
794-814: The implementation oftest_frame_field_namescorrectly tests the naming rules for frame fields in a dataset, including handling of reserved keywords.
Line range hint
816-880: The implementation oftest_field_schemascorrectly tests the retrieval of field schemas from a dataset based on various criteria.
Line range hint
882-946: The implementation oftest_frame_field_schemascorrectly tests the retrieval of frame field schemas from a dataset based on various criteria.
Line range hint
948-972: The implementation oftest_add_list_subfieldcorrectly tests the addition of subfields to list fields in a dataset.
Line range hint
974-994: The implementation oftest_onecorrectly tests the retrieval of a single sample from a dataset based on a filter.
Line range hint
996-1034: The implementation oftest_merge_samplecorrectly tests the merging of sample data in a dataset.
| if isinstance(classes, dict): | ||
| classes_map = classes | ||
| else: | ||
| classes_map = {i: label for i, label in enumerate(classes)} | ||
|
|
There was a problem hiding this comment.
Consider using a dictionary comprehension for clarity and efficiency.
- classes_map = {i: label for i, label in enumerate(classes)}
+ classes_map = dict(enumerate(classes))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| if isinstance(classes, dict): | |
| classes_map = classes | |
| else: | |
| classes_map = {i: label for i, label in enumerate(classes)} | |
| if isinstance(classes, dict): | |
| classes_map = classes | |
| else: | |
| classes_map = dict(enumerate(classes)) |
| "name": l, | ||
| "supercategory": None, | ||
| } | ||
| for i, l in enumerate(classes) |
There was a problem hiding this comment.
Ambiguous variable name 'l' can be confusing. Consider renaming it to a more descriptive name.
| class TestNumPyResponse(unittest.IsolatedAsyncioTestCase): | ||
| async def test_numpy_response(self): | ||
| await create_response( | ||
| { | ||
| "float16": np.array([16.0], dtype=np.float16), | ||
| "float32": np.array([32.0], dtype=np.float32), | ||
| "float64": np.array([64.0], dtype=np.float64), | ||
| "int8": np.array([8], dtype=np.int8), | ||
| "int16": np.array([8], dtype=np.int16), | ||
| "int32": np.array([8], dtype=np.int32), | ||
| "int64": np.array([8], dtype=np.int64), | ||
| "uint8": np.array([8], dtype=np.uint8), | ||
| "uint6": np.array([8], dtype=np.uint16), | ||
| "uint32": np.array([8], dtype=np.uint32), | ||
| "uint64": np.array([8], dtype=np.uint64), | ||
| } | ||
| ) |
There was a problem hiding this comment.
Add assertions to verify the output of create_response.
The test method test_numpy_response currently does not include any assertions to verify the output of the create_response function. It's crucial to add assertions to ensure that the function behaves as expected with various numpy data types.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- docs/source/integrations/huggingface.rst (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/source/integrations/huggingface.rst
* bug: use name arg in lights * add null checking when computing camera props * upgrade three.js deps * default name arg to class name in base class
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (2)
app/packages/looker-3d/package.jsonis excluded by!**/*.jsonapp/yarn.lockis excluded by!**/*.lock,!**/*.lock
Files selected for processing (2)
- app/packages/looker-3d/src/fo3d/MediaTypeFo3d.tsx (1 hunks)
- fiftyone/core/threed/lights.py (15 hunks)
Files not reviewed due to errors (1)
- fiftyone/core/threed/lights.py (no review received)
Additional Context Used
Path-based Instructions (1)
app/packages/looker-3d/src/fo3d/MediaTypeFo3d.tsx (1)
Pattern
**/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- docs/source/teams/roles_and_permissions.rst (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/source/teams/roles_and_permissions.rst
What changes are proposed in this pull request?
Merge release/v0.24.0 into develop
fiftyonePython library changesSummary by CodeRabbit
New Features
update_asset_pathsto update asset paths in 3D scenes.DeepSorttracking to handle individual video samples.Improvements
ImageContainerHeaderandViewBarfor better UI consistency.classesandcategoriesparameters.Bug Fixes
Tests
Chores