Add PlotlyView on_selected event for scatter plots #4385

ritch · 2024-05-10T04:33:31Z

Summary by CodeRabbit

New Features
- Enhanced interactivity in Plotly graphs with new event handling for clicks and selections.
- Introduced global execution context access across various components for improved state management.
- Expanded functionality in custom panels with additional context and dataset change handlers.
Enhancements
- Streamlined method names and increased available callbacks in panel operations for better clarity and functionality.
Bug Fixes
- Adjusted event handling logic to ensure robust and error-free user interactions.

coderabbitai · 2024-05-10T04:33:40Z

Warning

Rate Limit Exceeded

@ritch has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 26 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 3fc893d and 5ba14e1.

Walkthrough

The recent updates focus on enhancing event handling across various components and modules, introducing new callback functionalities, and refining context management. This includes better event response in PlotlyView.tsx, expanded functionality in custom panels, and the addition of global execution context handling, streamlining state management and interactivity within the application.

Changes

Files	Change Summary
`.../SchemaIO/components/PlotlyView.tsx`	Updated event handling and added `getValuesAtIndices` function.
`.../operators/src/CustomPanel.tsx`, `.../operators/src/useCustomPanelHooks.ts`	Renamed and added multiple functions for enhanced panel interaction.
`.../operators/src/index.ts`, `.../operators/src/state.ts`	Introduced `useGlobalExecutionContext` for better context management.
`.../operators/src/operators.ts`	Added getter methods and URI checks in `ExecutionContext`.
`fiftyone/operators/operations.py`, `fiftyone/operators/panel.py`	Updated to support new context change events and streamlined method handling.

🐇💻
A hop of code, a leap of function,
Through fields of logic, with deft construction.
Events captured, contexts switched,
In digital burrows, where bugs are ditched.
Celebrate the craft, as changes fuse,
In the warren of code, where rabbits muse. 🌟🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ritch · 2024-05-10T04:36:27Z

app/packages/core/src/plugins/SchemaIO/components/PlotlyView.tsx

+      const { x, y, z, ids, selectedpoints, ...metadata } = data;
+      selected.push({
+        idx: point.pointIndex,
+        id: Array.isArray(ids) ? ids[point.pointIndex] : null,


This makes ids a "known" parameter of view. This needs to be added to the docs for types.PlotlyView().

ritch · 2024-05-10T04:36:46Z

app/packages/core/src/plugins/SchemaIO/components/PlotlyView.tsx

 };

+function getValuesAtIndices(array, indices) {


Need to remove this as its no longer used.

ritch · 2024-05-10T04:37:19Z

app/packages/core/src/plugins/SchemaIO/components/PlotlyView.tsx

-    });
+    if (eventHandlerOperator) {
+      let params = {};
+      if (event === "onClick") {


Need to document this and the other event handler in types.PlotlyView().

imanjra

LGTM

plot on_selected panel event

5ba14e1

ritch force-pushed the plot-on-selected branch from 3fc893d to 5ba14e1 Compare May 10, 2024 04:35

ritch commented May 10, 2024

View reviewed changes

imanjra approved these changes May 10, 2024

View reviewed changes

ritch merged commit db4dcd8 into py-panels-develop May 21, 2024
6 checks passed

ritch deleted the plot-on-selected branch May 21, 2024 23:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PlotlyView on_selected event for scatter plots #4385

Add PlotlyView on_selected event for scatter plots #4385

ritch commented May 10, 2024 •

edited by coderabbitai bot

coderabbitai bot commented May 10, 2024 •

edited

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

ritch May 10, 2024

ritch May 10, 2024

ritch May 10, 2024

imanjra left a comment

Add PlotlyView on_selected event for scatter plots #4385

Add PlotlyView on_selected event for scatter plots #4385

Conversation

ritch commented May 10, 2024 • edited by coderabbitai bot

Summary by CodeRabbit

coderabbitai bot commented May 10, 2024 • edited

Rate Limit Exceeded

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

ritch May 10, 2024

Choose a reason for hiding this comment

ritch May 10, 2024

Choose a reason for hiding this comment

ritch May 10, 2024

Choose a reason for hiding this comment

imanjra left a comment

Choose a reason for hiding this comment

ritch commented May 10, 2024 •

edited by coderabbitai bot

coderabbitai bot commented May 10, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)