[WIP] Oit weighted - generalization #2230
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For convenience during implementation.
|
Ok, I pushed some more changes with very, very ugly patches to make Markers work. Take this just as a way to show what goes wrong and where. If you try the example now, you'll see that the markers show up, but are behaving strangely. Is this just a limitation of this kinf of rendering, due to the fact that points are actually opaque except for the aliasing edge? |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting this PR on the main repo in order to get feedback. This is a continuation on #2039, attempting to implement a generalization where each
Visualprovides anis_transparentflag.The new code is not clean (a lot of ugly
isinstanceandhasattr), but should work and provides a proof of concept.Unfortunately, I tried to add markers to the example and things fail; specifically, it's due to a couple of line (which @asnt already identified as problematic) where
_prepare_drawneeds to be called with no view (which causes all sort of error if the view is needed).