-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 9.1.0-alpha #8833
base: master
Are you sure you want to change the base?
Bump to 9.1.0-alpha #8833
Conversation
@@ -3,7 +3,7 @@ | |||
"description": "deck.gl layers that aggregate the input data into alternative representations", | |||
"license": "MIT", | |||
"type": "module", | |||
"version": "9.0.0-beta.11", | |||
"version": "9.1.0-alpha.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are managed by lerna, please don't edit them manually.
@@ -65,7 +65,8 @@ export default class TriangleLayer extends Layer<_TriangleLayerProps> { | |||
{name: 'positions', format: 'float32x3'}, | |||
{name: 'texCoords', format: 'float32x2'} | |||
], | |||
topology: 'triangle-fan-webgl', | |||
// TODO v9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly is the todo here?
dataFormat: 6402, // gl.DEPTH_COMPONENT | ||
type: 5125 // gl.UNSIGNED_INT | ||
// dataFormat: 6402, // gl.DEPTH_COMPONENT | ||
// type: 5125 // gl.UNSIGNED_INT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can delete these safely
@@ -251,8 +251,8 @@ export default class CollisionFilterEffect implements Effect { | |||
mipmaps: false, | |||
|
|||
// TODO fix getWebGLTextureParameters() in luma to avoid passing deprecated parameters | |||
dataFormat: 6402, // gl.DEPTH_COMPONENT | |||
type: 5125 // gl.UNSIGNED_INT | |||
// dataFormat: 6402, // gl.DEPTH_COMPONENT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can delete these safely
df4cb35
to
8cd89ca
Compare
Closes #
Background
Change List