Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: expose aggregate sum value for hierarchy transforms #1900

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ENH: expose aggregate sum value for hierarchy transforms #1900

wants to merge 5 commits into from

Conversation

tejesh0
Copy link

@tejesh0 tejesh0 commented Aug 6, 2019 •
edited by domoritz

fixes #1380

@domoritz domoritz changed the title ENH: expose aggregate sum value for hierarchy transforms, fixes #1380 ENH: expose aggregate sum value for hierarchy transforms Aug 6, 2019
@tejesh0 tejesh0 closed this Aug 7, 2019
@tejesh0 tejesh0 reopened this Aug 7, 2019
@tejesh0
Copy link
Author

tejesh0 commented Aug 7, 2019

could you please review, @domoritz

jheer
jheer reviewed Aug 21, 2019
View reviewed changes
docs/docs/transforms/pack.md Outdated Show resolved Hide resolved
jheer
jheer reviewed Aug 21, 2019
View reviewed changes
docs/docs/transforms/tree.md Outdated Show resolved Hide resolved
@jheer
Copy link
Member

jheer commented Aug 21, 2019

Thanks for working on this PR! Please see my notes for needed fixes.

Also, it would be helpful to document why this change is needed and valuable. In particular, I'd love to see a test specification that demonstrates the feature and its use.

@tejesh0
Copy link
Author

tejesh0 commented Aug 25, 2019

Currently, sum value is implicitly encoded to relevant hierarchy transform's core mark properties. With value being exposed, other mark properties like fill, opacity, stroke etc., can be encoded too.

This change enables the creation of these examples in Vega:

https://gramener.com/fmcg/
https://gramener.com/treemap/treemap?app=Nutrition

@kanitw kanitw requested a review from a team as a code owner May 20, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jheer jheer jheer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Treemap - Not able to retrieve aggregate values and parent object
2 participants
@tejesh0 @jheer