fix smb password expired vs account expired confusion #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra-smb.c
Outdated
| @@ -1311,7 +1311,7 @@ int32_t start_smb(int32_t s, char *ip, int32_t port, unsigned char options, char | |||
| } else if (SMBerr == 0x000071) { /* password expired */ | |||
| if (verbose) | |||
| fprintf(stderr, "[%d][smb] Host: %s Account: %s Error: PASSWORD EXPIRED\n", port, ipaddr_str, login); | |||
There was a problem hiding this comment.
I think "Error" in that line is then not helpful? Maybe change it to "Information"?
There was a problem hiding this comment.
Absolutely, "Information" is much better.
|
looks good just one minor nit |
|
@tothi can you please fix the "Error" string to "Information" so I can merge this? thanks you |
|
Carynw_ Instagram password |
fixed logging (if found -> hydra_report to stdout with Information instead of Error)
|
added some logging fix. sorry for the super long delay, totally forgot it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing is in this thread: https://twitter.com/an0n_r0/status/1731109539204710416
Originally Hydra returned valid if the account was expired but invalid if the password was expired. It is wrong, it should be exactly the opposite: valid if password was expired, but invalid if account was expired.