Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fbp 85 expanded collapsed process contd #286

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

valb3r
Copy link
Owner

@valb3r valb3r commented Nov 21, 2021

Fixes #85

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2021

Codecov Report

Merging #286 (5632c89) into master (b58c4f1) will decrease coverage by 0.15%.
The diff coverage is 52.54%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #286      +/-   ##
============================================
- Coverage     62.24%   62.08%   -0.16%     
- Complexity     1288     1300      +12     
============================================
  Files           185      185              
  Lines          6150     6209      +59     
  Branches        826      832       +6     
============================================
+ Hits           3828     3855      +27     
- Misses         2054     2083      +29     
- Partials        268      271       +3     
Flag Coverage Δ
unittests 62.08% <52.54%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../bpmn/intellij/plugin/core/render/RenderContext.kt 87.50% <ø> (-12.50%) ⬇️
...in/core/render/elements/anchors/VirtualWaypoint.kt 88.88% <ø> (ø)
...n/core/render/elements/buttons/ButtonWithAnchor.kt 0.00% <0.00%> (ø)
...ender/elements/shapes/AnyShapeNestableIconShape.kt 79.59% <0.00%> (-3.39%) ⬇️
...re/render/elements/shapes/ExpandableShapeNoIcon.kt 0.00% <0.00%> (ø)
...ore/render/elements/viewtransform/ViewTransform.kt 30.40% <20.51%> (-1.04%) ⬇️
...j/plugin/core/render/DefaultBpmnProcessRenderer.kt 68.51% <50.00%> (+0.29%) ⬆️
.../core/render/elements/shapes/ShapeRenderElement.kt 82.75% <73.33%> (-1.18%) ⬇️
...ore/render/elements/edges/BaseEdgeRenderElement.kt 73.41% <76.47%> (+2.58%) ⬆️
...n/core/render/elements/BaseDiagramRenderElement.kt 85.04% <100.00%> (+0.73%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b58c4f1...5632c89. Read the comment docs.

@valb3r valb3r marked this pull request as draft November 24, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for collapsed subprocess
2 participants