fix: allow LIMIT 0 for SELECT queries #918
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygabuev
force-pushed
the
master
branch
9 times, most recently
from
690f449
to
a7b3e02
Compare
This commit enables the correct queries of type `SELECT ... LIMIT 0`. Before that, the limit-clause wasn't applied to the query.
|
The new tests fail for If this is true, it might be a better idea to fix those in a separate PR. UPD: this ticket seems related #811 |
vmihailenco
reviewed
Jan 6, 2024
| @@ -31,7 +31,7 @@ type SelectQuery struct { | |||
| group []schema.QueryWithArgs | |||
| having []schema.QueryWithArgs | |||
| order []schema.QueryWithArgs | |||
| limit int32 | |||
| limit *int32 | |||
There was a problem hiding this comment.
let's use sql.NullInt32 here
|
@ygabuev this looks good, but I can't merge a PR that breaks the build.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the correct queries of form
SELECT ... LIMIT 0.Before that, the limit-clause wasn't applied to the query.
Closes #801