Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure that Platform is specified by default in Release #16720

Merged
merged 2 commits into from
May 15, 2024
Merged

fix: Ensure that Platform is specified by default in Release #16720

merged 2 commits into from
May 15, 2024

Conversation

jeromelaban
Copy link
Member

GitHub Issue (If applicable): related to #16662

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

Building with no Platform set will use the current OS platform.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/5.2

@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2024 •
edited

backport release/stable/5.2

✅ Backports have been created

@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label May 14, 2024
@jeromelaban jeromelaban mentioned this pull request May 14, 2024
Closed
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16720/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16720/index.html

@nventive-devops
Copy link
Contributor

The build 125024 found UI Test snapshots differences: android-28-net7: 17, android-28-net7-Snap: 33, ios: 6, ios-Snap: 84, skia-gtk-screenshots: 51, skia-linux-screenshots: 76, skia-windows-screenshots: 54, wasm: 660, wasm-automated-net7.0-UWP-Default-automated: 124, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0

Details

  • android-28-net7: 17 changed over 829

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • DatePicker_PickerFlyout_PlacementsbottomLeft_True_False_True_UITests_Windows_UI_Xaml_Controls_DatePicker_DatePicker_Placement
    • Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
    • Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
    • NavigateBackAndForthBetweenMenuItemsAndSettings_Fluent_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
    • SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
    • Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
    • UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
    • When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • When_InListView_after_scroll
    • When_InScrollViewer_after_scroll
    • DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage

  • android-28-net7-Snap: 33 changed over 1059

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView_ListViewIncrementalLoading_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewIncrementalLoading
    • BreadcrumbBar_MUXControlsTestApp_BreadcrumbBarPage_MUXControlsTestApp_BreadcrumbBarPage
    • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • MUX_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage
    • MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromMsAppData_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromMsAppData
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons
    • Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage
    • TextBox_TextBox_Foreground_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_Foreground
    • TextBox_TextBox_Formatting_Flicker_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_Formatting_Flicker
    • TextBox_TextBox_Header_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_Header
    • TextBox_TextBox_HorizontalAlignment_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_HorizontalAlignment
    • ListView_ListViewLarge_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewLarge
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
    • Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
    • SwipeControl_UITests_Windows_UI_Xaml_Controls_SwipeControlTests_SwipeControl_ScrollViewer_UITests_Windows_UI_Xaml_Controls_SwipeControlTests_SwipeControl_ScrollViewer
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • Thumb_UITests_Windows_UI_Xaml_Controls_ThumbTests_Thumb_DragEvents_UITests_Windows_UI_Xaml_Controls_ThumbTests_Thumb_DragEvents
    • ToggleSwitch_Native_ToggleSwitch_IsOn_SamplesApp_Windows_UI_Xaml_Controls_ToggleSwitchControl_Native_ToggleSwitch_IsOn

  • ios: 6 changed over 269

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure

  • ios-Snap: 84 changed over 1050

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
    • Path_PathTime_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_PathTime
    • Path_PathVerticalOffsetAdjustable_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_PathVerticalOffsetAdjustable
    • Path_FixedWidth_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_FixedWidth
    • Path_Invisible_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_Invisible
    • Path_PathBindingOnData_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_PathBindingOnData
    • TextBlock_Simple_Contrained_Horizontal_Center_Wrap2_Uno_UI_Samples_Content_UITests_TextBlockControl_Simple_Contrained_Horizontal_Center_Wrap2
    • TextBlock_Simple_Text_Uno_UI_Samples_Content_UITests_TextBlockControl_Simple_Text
    • TextBlock_Textblocktimespancustomformat_Uno_UI_Samples_Content_UITests_TextBlockControl_Textblocktimespancustomformat
    • TextBlock_TextBlock_CharacterSpacing_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_CharacterSpacing
    • NumberBox_UITests_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBox_Header_UITests_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBox_Header
    • Other_controls_ChatBox_UITests_Shared_Windows_UI_Xaml_Controls_ChatBox_ChatBox
    • PagerControl_UITests_Microsoft_UI_Xaml_Controls_PagerControlTests_PagerControlPage_UITests_Microsoft_UI_Xaml_Controls_PagerControlTests_PagerControlPage
    • Page_UITests_Windows_UI_Xaml_Controls_PageTests_Page_Automated_UITests_Windows_UI_Xaml_Controls_PageTests_Page_Automated
    • TextBlock_SimpleText_MaxLines_One_Uno_UI_Samples_Content_UITests_TextBlockControl_SimpleText_MaxLines_One
    • TextBlock_SimpleText_MaxLines_Two_with_Different_Fonts_Uno_UI_Samples_Content_UITests_TextBlockControl_SimpleText_MaxLines_Two_with_Different_Fonts
    • Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • TextBlock_TextBlock_Hyperlink_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Hyperlink
    • TextBlock_TextBlock_Inlines_TemplatedParent_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Inlines_TemplatedParent

  • skia-gtk-screenshots: 51 changed over 2190

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • FluentStyle_NavigationViewSample.png
    • VisualState_AdaptiveTrigger_Storyboard.png-dark
    • VisualState_AdaptiveTrigger_Storyboard.png
    • Window_SetBackground.png-dark
    • Window_SetBackground.png
    • ColorPickerSample.png
    • PanelImageBrush.png
    • RectanglemaskingRectangleGrid.png
    • TransformToVisual_Simple.png-dark
    • TransformToVisual_Simple.png
    • ImageSourceUrlMsAppDataScheme.png-dark
    • ImageSourceUrlMsAppDataScheme.png
    • Ellipse.png-dark
    • Ellipse.png
    • FluentStyle_NavigationViewSample.png-dark
    • UIElement_InitializationSequence.png-dark
    • UIElement_InitializationSequence.png
    • ImageBrushInList.png-dark
    • ImageBrushInList.png
    • LargeImageList.png-dark

  • skia-linux-screenshots: 76 changed over 2190

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AutomationProperties_Name.png
    • ImageBrush_StreamSource.png-dark
    • ImageBrush_StreamSource.png
    • ImageBrush_UniformToFill.png-dark
    • ImageBrush_UniformToFill.png
    • BorderImageBrushRelativeTransform.png-dark
    • FluentStyle_NavigationViewSample.png-dark
    • FluentStyle_NavigationViewSample.png
    • ImageBrushInList.png-dark
    • ImageBrushInList.png
    • AutomationProperties_Name.png-dark
    • BorderImageBrushRelativeTransform.png
    • ImageBrushAlignmentXY.png-dark
    • ImageBrushAlignmentXY.png
    • ImageBrushAlignmentXY2.png-dark
    • ImageBrushAlignmentXY2.png
    • CalendarView_Theming.png-dark
    • DoubleImageBrushInList.png-dark
    • DoubleImageBrushInList.png
    • ImageWithLateSourceUniformToFill.png-dark

  • skia-windows-screenshots: 54 changed over 2190

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ImageSourceUrlMsAppDataScheme.png-dark
    • ImageSourceUrlMsAppDataScheme.png
    • BorderImageBrush.png-dark
    • ImageBrushInList.png-dark
    • ImageBrushInList.png
    • CalendarView_Theming.png-dark
    • Ellipse.png-dark
    • Ellipse.png
    • FluentStyle_NavigationViewSample.png-dark
    • FluentStyle_NavigationViewSample.png
    • ImagesInlineInFlipView.png-dark
    • ImagesInlineInFlipView.png
    • Image_Stretch_None_ScrollViewer.png-dark
    • Image_Stretch_None_ScrollViewer.png
    • BorderImageBrush.png
    • ImageBrush_Formats.png-dark
    • ImageBrush_Formats.png
    • CalendarView_Theming.png
    • ImageIconPage.png-dark
    • ImageIconPage.png

  • wasm: 660 changed over 1040

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.NavigationViewStretchPage
    • MUXControlsTestApp.RefreshContainerPage
    • SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_AnchorNavigation
    • SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_ChromeClient
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_IsSelected
    • SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.Grid_With_RotateTransform_And_Button
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewContainerFromItem
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewDynamicOrientation
    • SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.FixedWidthUniform
    • SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.HorizontalAlignmentStretchVerticalAlignmentBottom
    • UITests.Microsoft_UI_Xaml_Controls.ColorPickerTests.ColorPickerSample
    • UITests.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_ExecuteScriptAsync
    • UITests.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_NavigationProperties
    • UITests.Shared.Windows_Devices.Midi.MidiDeviceOutputTests
    • UITests.Shared.Windows_Globalization.Language_Properties
    • UITests.Shared.Windows_UI_Xaml.xBind.xBind
    • UITests.Shared.Windows_UI_Xaml.xBindTests.xBind_Field
    • UITests.Shared.Windows_UI_Xaml.xBindTests.xBind_Functions
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_Explicit_Items
    • UITests.Shared.Windows_UI_Xaml_Controls.TextBlockControl.TextBlock_Foreground_While_Collapsed

  • wasm-automated-net7.0-UWP-Default-automated: 124 changed over 1958

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Check_ListView_Swallows_Measure_after_scroll
    • Check_ListView_Swallows_Measure_before_scroll
    • FocusManager_GetFocusedElement_Grid_Validation_FocusManager_-_GetFocusedElement_-_Grid_-_1_-_Initial_State
    • FocusManager_GetFocusedElement_Grid_Validation_FocusManager_-_GetFocusedElement_-_Grid_-_2_-_After_Selection
    • FocusManager_GetFocusedElement_Grid_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • FocusManager_GetFocusedElement_HyperlinkButton_LostFocus_Validation_FocusManager_-_LostFocus_-_HyperlinkButton_-_1_-_Initial_State
    • FocusManager_GetFocusedElement_TextBlock_Validation_FocusManager_-_GetFocusedElement_-_TextBlock_-_1_-_Initial_State
    • FocusManager_GetFocusedElement_TextBlock_Validation_FocusManager_-_GetFocusedElement_-_TextBlock_-_2_-_After_Selection
    • FocusManager_GetFocusedElement_TextBlock_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • FocusManager_GetFocusedElement_TextBoxMultiLine_LostFocus_Validation_FocusManager_-_LostFocus_-_TextBoxMultiLine_-_1_-_Initial_State
    • FocusManager_GetFocusedElement_TextBoxMultiLine_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • FocusManager_GetFocusedElement_TextBoxSingleLine_LostFocus_Validation_FocusManager_-_LostFocus_-_TextBoxSingleLine_-_1_-_Initial_State
    • FocusManager_GetFocusedElement_TextBoxSingleLine_LostFocus_Validation_FocusManager_-_LostFocus_-_TextBoxSingleLine_-_2_-_Click_outside
    • FocusManager_GetFocusedElement_TextBoxSingleLine_LostFocus_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • FocusManager_GetFocusedElement_ListViewItem_Validation_FocusManager_-_GetFocusedElement_-_ListViewItem_-_2_-_After_Selection
    • FocusManager_GetFocusedElement_ListViewItem_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • FocusManager_GetFocusedElement_Rectangle_Validation_FocusManager_-_GetFocusedElement_-_Rectangle_-_1_-_Initial_State
    • FocusManager_GetFocusedElement_Rectangle_Validation_FocusManager_-_GetFocusedElement_-_Rectangle_-_2_-_After_Selection
    • FocusManager_GetFocusedElement_CheckBox_LostFocus_Validation_FocusManager_-_LostFocus_-_CheckBox_-_1_-_Initial_State
    • FocusManager_GetFocusedElement_CheckBox_LostFocus_Validation_FocusManager_-_LostFocus_-_CheckBox_-_3_-_Click_outside

  • wasm-automated-net7.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-UWP-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net7.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net7.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-2: 0 changed over 1

@jeromelaban jeromelaban merged commit 1cc31e9 into master May 15, 2024
103 checks passed
@jeromelaban jeromelaban deleted the dev/jela/win-build branch May 15, 2024 12:36
@mergify mergify bot mentioned this pull request May 15, 2024
Merged
6 tasks
jeromelaban added a commit that referenced this pull request May 15, 2024
@jeromelaban
Merge pull request #16737 from unoplatform/mergify/bp/release/stable/…
a7b82e3 
…5.2/pr-16720

fix: Ensure that Platform is specified by default in Release (backport #16720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinZikmund MartinZikmund MartinZikmund approved these changes

@agneszitte agneszitte agneszitte approved these changes

Assignees
No one assigned
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeromelaban @unodevops @nventive-devops @MartinZikmund @agneszitte