fix: Fix FlipView SelectedIndex not changing with touch swipes on Wasm #16666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform/wasm 🌐
agneszitte
reviewed
May 9, 2024
src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.wasm.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.wasm.cs
Show resolved
Hide resolved
ajpinedam
approved these changes
May 9, 2024
Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
github-actions
bot
added
the
area/automation
MartinZikmund
approved these changes
May 10, 2024
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16666/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16666/index.html |
dr1rrb
reviewed
May 10, 2024
| var horizontalOffset = GetNativeHorizontalOffset(); | ||
| var verticalOffset = GetNativeVerticalOffset(); | ||
| var isIntermediate = |
There was a problem hiding this comment.
Is it possible that _lastScrollToRequest is "not possible" (i.e. one of the offset is out of the scrollable range)? Also should we consider some rounding issue and accept like a 1px range?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #15277
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):