fix(wpf): Fix IsLeftButtonPressed status on WPF platform #16517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/skia ✏️
6 tasks
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16517/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16517/index.html |
dr1rrb
approved these changes
May 8, 2024
agneszitte
reviewed
May 9, 2024
| @@ -111,7 +111,9 @@ public void ReleasePointerCapture() | |||
| => _hostControl.ReleaseMouseCapture(); | |||
|
|
|||
| #region Native events | |||
| private void HostOnMouseEvent(InputEventArgs args, TypedEventHandler<object, PointerEventArgs>? @event, [CallerArgumentExpression(nameof(@event))] string eventName = "") | |||
|
|
|||
There was a problem hiding this comment.
@jeromelaban, @dr1rrb should we add more tests related to these changes?
There was a problem hiding this comment.
A manual test would be useful, if we don't have any.
There was a problem hiding this comment.
@jeromelaban Any update here? Or what should I do? Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #14393
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We can receive the pointer event with IsLeftButtonPressed is true when touch release.
What is the new behavior?
We can receive the pointer event with IsLeftButtonPressed is false when touch release.
See https://github.com/unoplatform/uno/pull/16378/files#r1575262313
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Cc @dr1rrb , and I will add more information about the barel button and the eraser status later.
Internal Issue (If applicable):