Skia shapes hittesting #16201
Skia shapes hittesting #16201
Conversation
github-actions
bot
added
area/skia ✏️
|
this builds on top of #15875 |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16201/index.html |
| internal SKPath? LastDrawnStrokePath { get; private set; } | ||
| internal SKPath? LastDrawnFillPath { get; private set; } |
There was a problem hiding this comment.
Not sure if there is an unmanaged memory leak here.
There was a problem hiding this comment.
Yeah, I noticed that too. According to the documentation, the unmanaged memory will be freed in the managed object's destructor.
There was a problem hiding this comment.
Especially this they are no longer disposed.
There was a problem hiding this comment.
Disposing sometimes throws weird native errors. It should be safe to not dispose. The remark on Dispose says this:
Always dispose the object before you release your last reference to the . Otherwise, the resources it is using will not be freed until the garbage collector calls the finalizer.
There was a problem hiding this comment.
Not disposing and relying on the GC may have performance impacts, I think. Finalizers aren't cheap, and an explicit Dispose call should be calling GC.SuppressFinalize (inside SkiaSharp)
What errors did you get when disposing?
|
|
||
| stroke.UpdatePaint(fillPaint, strokeGeometry.Bounds); | ||
|
|
||
| LastDrawnStrokePath = strokeGeometry; |
There was a problem hiding this comment.
Should we dispose the previous one here?
| internal SKPath? LastDrawnStrokePath { get; private set; } | ||
| internal SKPath? LastDrawnFillPath { get; private set; } |
There was a problem hiding this comment.
Especially this they are no longer disposed.
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16201/index.html |
ramezgerges
force-pushed
the
skia_shapes_hittesting
branch
from
f9c77d1
to
0219d0c
Compare
github-actions
bot
removed
the
area/automation
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16201/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16201/index.html |
GitHub Issue (If applicable): closes #15855
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):