-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Updated ArcGisApp docs #2293
Conversation
eceb8d9
to
290b41e
Compare
290b41e
to
19a66ca
Compare
@vatsashah45 sorry just catching up now but just want to make sure we have deployed this locally with docfx to make sure there are no formatting errors? It may render differently with docfx than other markdown previewers |
@kazo0 I already did that yesterday while doing a couple of fixes that I pushed on this branch in addition to @vatsashah45 changes. We shared these details with him already (cf. #2293 (comment)) @vatsashah45 make sure to do the same for DevExpress before we review #2296 please |
@agneszitte @kazo0 @eriklimakc All the comments are resolved now. And I've tested the docs with docfx. Let me know if this PR's good to merge :) |
@agneszitte does this need a backport once we merge the single project PR? |
@Mergifyio backport release/stable/4.1 |
✅ Backports have been created
|
Yes @kazo0 that was planned for the backport |
….1/pr-2293 docs: Updated ArcGisApp docs (backport #2293)
GitHub Issue (If applicable): https://github.com/unoplatform/uno.samples-private/issues/146
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):