Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated ArcGisApp docs #2293

Merged
merged 11 commits into from
May 30, 2024
Merged

docs: Updated ArcGisApp docs #2293

merged 11 commits into from
May 30, 2024

Conversation

vatsashah45
Copy link
Contributor

@vatsashah45 vatsashah45 commented May 14, 2024

GitHub Issue (If applicable): https://github.com/unoplatform/uno.samples-private/issues/146

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

doc/Learn/Maui/ThirdParty-EsriMaps.md Outdated Show resolved Hide resolved
doc/Learn/Maui/ThirdParty-EsriMaps.md Outdated Show resolved Hide resolved
@agneszitte agneszitte force-pushed the dev/vs/arcgis-docs branch 2 times, most recently from eceb8d9 to 290b41e Compare May 29, 2024 19:59
@kazo0
Copy link
Contributor

kazo0 commented May 30, 2024

@vatsashah45 sorry just catching up now but just want to make sure we have deployed this locally with docfx to make sure there are no formatting errors? It may render differently with docfx than other markdown previewers

@agneszitte
Copy link
Contributor

agneszitte commented May 30, 2024

@vatsashah45 sorry just catching up now but just want to make sure we have deployed this locally with docfx to make sure there are no formatting errors? It may render differently with docfx than other markdown previewers

@kazo0 I already did that yesterday while doing a couple of fixes that I pushed on this branch in addition to @vatsashah45 changes. We shared these details with him already (cf. #2293 (comment))

@vatsashah45 make sure to do the same for DevExpress before we review #2296 please

@vatsashah45
Copy link
Contributor Author

@agneszitte @kazo0 @eriklimakc

All the comments are resolved now. And I've tested the docs with docfx.

Let me know if this PR's good to merge :)

@kazo0
Copy link
Contributor

kazo0 commented May 30, 2024

@agneszitte does this need a backport once we merge the single project PR?

@agneszitte
Copy link
Contributor

@Mergifyio backport release/stable/4.1

Copy link

mergify bot commented May 30, 2024

backport release/stable/4.1

✅ Backports have been created

@agneszitte
Copy link
Contributor

@agneszitte does this need a backport once we merge the single project PR?

Yes @kazo0 that was planned for the backport
@vatsashah45 I will review quickly the last changes in a few minutes before merging everything

@agneszitte agneszitte merged commit 9383e7e into main May 30, 2024
6 of 7 checks passed
@agneszitte agneszitte deleted the dev/vs/arcgis-docs branch May 30, 2024 21:41
agneszitte added a commit that referenced this pull request May 30, 2024
….1/pr-2293

docs: Updated ArcGisApp docs (backport #2293)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants