docs: Add Binding to DataTemplates docs #2292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriklimakc
force-pushed
the
dev/erli/csm-datatemplate-binding
branch
from
05314c1
to
4258557
Compare
agneszitte
reviewed
May 14, 2024
kazo0
approved these changes
May 16, 2024
agneszitte
approved these changes
May 17, 2024
|
@Mergifyio backport release/stable/4.1 |
🟠 Waiting for conditions to match
|
kazo0
approved these changes
May 28, 2024
Xiaoy312
approved these changes
May 28, 2024
|
@dansiegel, @nickrandolph if you can give a last review before we merge please |
eriklimakc
commented
May 30, 2024
| private Button CreateRemoveButton() => new Button() | ||
| .Content("Delete") | ||
| .CommandParameter(x => x | ||
| .RelativeSource<Button>(RelativeSourceMode.TemplatedParent) |
There was a problem hiding this comment.
We have an inconsistency issue here:
RelativeSource as TemplatedParent works on Windows but not on Uno
RelativeSource as Self works on Uno but not on Windows
Should be fixed by unoplatform/uno#12732
There was a problem hiding this comment.
Uno issue: unoplatform/uno#16940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #679
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):