Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add CSM CallBack usage to Name method #2279

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

eriklimakc
Copy link
Contributor

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the new behavior?

Adds an example of how to use the .Name method with a callback.

@eriklimakc eriklimakc requested a review from dansiegel May 6, 2024 16:54
@eriklimakc eriklimakc requested a review from agneszitte May 8, 2024 18:53
@agneszitte
Copy link
Contributor

@Mergifyio backport release/stable/4.1

Copy link

mergify bot commented May 8, 2024

backport release/stable/4.1

✅ Backports have been created

doc/Learn/Markup/toc.yml Outdated Show resolved Hide resolved
@agneszitte agneszitte requested review from kazo0 and dr1rrb May 9, 2024 16:06
@eriklimakc eriklimakc force-pushed the dev/erli/update-csm-name-method branch from 09f3ba5 to deec6a3 Compare May 9, 2024 16:33
Copy link
Contributor Author

@eriklimakc eriklimakc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

```cs
new TextBlock()
.Text(x => x
.Source("slider")
.Binding(() => slider.Value)),
new Slider().Name("slider")
```

This example should probably be:

new TextBlock()
	.Text(x => x
	         .Source("slider")
	         .Binding<Slider>(slider => slider.Value)),
new Slider().Name("slider"))

@dansiegel Can you confirm please?

cc @agneszitte


This was already resolved, no need to reply to this comment.

@eriklimakc eriklimakc force-pushed the dev/erli/update-csm-name-method branch from f9d6fb5 to 5ff9063 Compare May 16, 2024 08:17
@eriklimakc eriklimakc added the kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project label Jun 4, 2024
@eriklimakc eriklimakc self-assigned this Jun 4, 2024
doc/Learn/Markup/Appendix/AccessingControlInstance.md Outdated Show resolved Hide resolved
doc/Learn/Markup/Styles.md Outdated Show resolved Hide resolved
@dansiegel dansiegel merged commit c2cd547 into main Jun 12, 2024
6 of 7 checks passed
@dansiegel dansiegel deleted the dev/erli/update-csm-name-method branch June 12, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants