Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Overview.md #1920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sherifelantil
Copy link

Replaced the MVUX model class name "WeatherModel" with "MainModel" to be consistent with the code description.

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

The MVUX code sample included a typo where the Model class was named "WeatherModel" while it was called "MainModel" in the rest of the document.

What is the new behavior?

The MVUX code sample is now consistent with the rest of the document.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Replaced the MVUX model class name "WeatherModel" with "MainModel" to be consistent with the code description.
@nickrandolph
Copy link
Contributor

@sherifelantil are you able to address the conventional commits fail by updating the comment for your commit

@nickrandolph nickrandolph changed the title Update Overview.md chore: Update Overview.md Nov 13, 2023
@nickrandolph
Copy link
Contributor

@sherifelantil can you change the mesasage on your commit to start with "chore: " so we can merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants