Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): fix button visibility when grid column/row is zero #1194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Arieldelossantos
Copy link
Contributor

GitHub Issue: #1188

PR Type

What kind of change does this PR introduce?

  • Bugfix

Description

Wasm

Before After
WASM-button-before WASM-button-after

Android

Before After
AND-button-before AND-button-after

GTK

Before After
GTK-button-before GTK-button-after

iOS

Before After
iOS-button-before iOS-button-iOS

PR Checklist

Please check if your PR fulfills the following requirements:

Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue mentions that things are working properly on Windows already, so that would mean it's bug in core uno.

Can you please confirm if this still reproduces on Skia with latest Uno dev? Recently, there were improvements to the measure/arrange phases for Skia and Wasm.

@kazo0
Copy link
Collaborator

kazo0 commented Oct 11, 2023

The issue mentions that things are working properly on Windows already, so that would mean it's bug in core uno.

Can you please confirm if this still reproduces on Skia with latest Uno dev? Recently, there were improvements to the measure/arrange phases for Skia and Wasm.

@Arieldelossantos can you confirm if this is still an issue without this fix?

@Arieldelossantos
Copy link
Contributor Author

Confirmed that issue still occurs with Uno 5.0.0-dev.3431 on platforms Android, GTK, Wasm and iOS on master without the fix
cc.: @kazo0 @Youssef1313

@Arieldelossantos Arieldelossantos force-pushed the dev/arde/fix-button-visibility-when-grid-cell-is-zero branch from ab3d0f9 to 6218f02 Compare October 11, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button partially visible even in a zero width&height container
4 participants