fix: Slider styles #1154
Open
fix: Slider styles #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1154.eastus2.azurestaticapps.net |
agneszitte
reviewed
Aug 25, 2023
| @@ -96,9 +97,10 @@ | |||
| <x:Double x:Key="SliderThumbWidth">20</x:Double> | |||
| <x:Double x:Key="SliderThumbHeight">20</x:Double> | |||
| <x:Double x:Key="SliderThumbCornerRadius">10</x:Double> | |||
| <StaticResource x:Key="SliderTrackCornerRadius" ResourceKey="ControlCornerRadius" /> | |||
| <Thickness x:Key="SliderThumbMargin">-1</Thickness> | |||
There was a problem hiding this comment.
Not sure if negative margin is the way to go here as it is affecting the thumb position to be perfectly centered for the proper value (for example moving the thumb on slider value 50 will move the thumb centered to 49 with this change I think). Will need to be verified
|
Hi everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: https://github.com/unoplatform/Uno.Figma/issues/609
PR Type
What kind of change does this PR introduce?
Description
Before:
Now:
PR Checklist
Other information
Internal Issue (If applicable):
https://github.com/unoplatform/Uno.Figma/issues/609