feat: added PipsPager lightweight styling cm #1129
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramezgerges
previously requested changes
Sep 22, 2023
kazo0
reviewed
Sep 23, 2023
Marc-Antoine-Soucy
force-pushed
the
dev/maso/lightweightpipspager2
branch
from
7ffabfc
to
a9695a2
Compare
|
@kazo0 Should Main Ellipse be => Pipspage.Ressource.SelectionIndicatorButton.MainEllipse like this, since it's only a part of the SelectionIndicatorButton? |
Marc-Antoine-Soucy
changed the title
kazo0
reviewed
Sep 26, 2023
Marc-Antoine-Soucy
force-pushed
the
dev/maso/lightweightpipspager2
branch
from
a9695a2
to
592041a
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1129.eastus2.azurestaticapps.net |
kazo0
force-pushed
the
dev/maso/lightweightpipspager2
branch
from
6372a3c
to
8c9a503
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1129.eastus2.azurestaticapps.net |
kazo0
force-pushed
the
dev/maso/lightweightpipspager2
branch
from
8c9a503
to
485bc5e
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1129.eastus2.azurestaticapps.net |
auto-merge was automatically disabled
October 6, 2023 17:54
Pull request was converted to draft
|
Let's revisit if this PR is still needed after @Xiaoy312 current work with a script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
PR Type
What kind of change does this PR introduce?
Description
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):