Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add PongWars sample #675

Merged
merged 15 commits into from
May 9, 2024
Merged

feat: Add PongWars sample #675

merged 15 commits into from
May 9, 2024

Conversation

morning4coffe-dev
Copy link
Member

Add a sample for UnoPongWars minigame.

@agneszitte agneszitte marked this pull request as draft April 30, 2024 21:30
@dr1rrb dr1rrb mentioned this pull request May 1, 2024
Closed
@agneszitte agneszitte mentioned this pull request May 1, 2024
Closed
@agneszitte agneszitte marked this pull request as ready for review May 9, 2024 00:06
@agneszitte
Copy link
Contributor

agneszitte commented May 9, 2024 •
edited

@jeromelaban, @dansiegel right now I can see this error : The platform 'AnyCPU' is not supported for Self Contained mode. for the CI Build and locally for release as well.

Does something need to be fixed in Templates? Or it is something else?
@morning4coffe-dev created a new solution on Monday (related commit f17249c).
Not sure if it was like that by default. @morning4coffe-dev did you change some things manually?

@morning4coffe-dev
Copy link
Member Author

agneszitte, I didn't change anything in the configuration when creating a new project from the template via wizard. I can reproduce the issue when creating a new Recommended project with 'VS Extension 5.2.46.54'

@MartinZikmund
Copy link
Member

@agneszitte @morning4coffe-dev That error is fixed in the single project branch - I suggest just cherry-picking this commit, as this should be merged sooner - 81817c2

morning4coffe-dev and others added 15 commits May 9, 2024 14:55
@MartinZikmund
Copy link
Member

Rebased on latest master which includes the fix, this should now pass CI

@agneszitte
Copy link
Contributor

agneszitte commented May 9, 2024 •
edited

Rebased on latest master which includes the fix, this should now pass CI

Great for the CI Build, but locally for Release @MartinZikmund, @jeromelaban?

[Update] I have opened an issue for it unoplatform/uno#16662

@agneszitte agneszitte merged commit ad049be into master May 9, 2024
7 checks passed
@agneszitte agneszitte deleted the dev/doti/add-pw-sample branch May 9, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte left review comments

@MartinZikmund MartinZikmund MartinZikmund approved these changes

@nickrandolph nickrandolph nickrandolph approved these changes

@dr1rrb dr1rrb Awaiting requested review from dr1rrb

@jeromelaban jeromelaban Awaiting requested review from jeromelaban

@kazo0 kazo0 Awaiting requested review from kazo0

Assignees

@agneszitte agneszitte

@morning4coffe-dev morning4coffe-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@morning4coffe-dev @agneszitte @MartinZikmund @nickrandolph