Revamp Gradle scripts #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteiger
force-pushed
the
gradle-improvements
branch
3 times, most recently
from
1dd72b5
to
e3436dd
Compare
psteiger
force-pushed
the
gradle-improvements
branch
6 times, most recently
from
95689bd
to
88ae07b
Compare
psteiger
force-pushed
the
gradle-improvements
branch
2 times, most recently
from
9bea86e
to
a1c50fd
Compare
psteiger
force-pushed
the
gradle-improvements
branch
from
a1c50fd
to
956aebf
Compare
psteiger
force-pushed
the
gradle-improvements
branch
from
956aebf
to
627a229
Compare
psteiger
force-pushed
the
gradle-improvements
branch
from
627a229
to
22b4f2a
Compare
tyvsmith
reviewed
May 18, 2023
| implementation deps.kotlin.coroutinesRx2 | ||
| implementation deps.uber.autodisposeCoroutines | ||
| implementation deps.uber.motif | ||
| kapt(libs.motif.compiler) |
There was a problem hiding this comment.
Not that we should increase the scope of this diff, but we should move this to KSP motif.
Tracking here #591
tyvsmith
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #590
dependencies.gradlefile.subprojectsorallprojects, which we currently do, is discouraged.apply pluginis discouraged.