Implement MultiUpsert method in client and expose it via the Client interface #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgode
force-pushed
the
mgode/implement-multi-endpoints-client
branch
from
8763c7b
to
1ad1a8c
Compare
jc-fireball
reviewed
Apr 25, 2018
client.go
Outdated
| @@ -151,7 +153,7 @@ type Client interface { | |||
| // given RemoveRangeOp. | |||
| RemoveRange(ctx context.Context, removeRangeOp *RemoveRangeOp) error | |||
|
|
|||
| // TODO: Coming in v2.1 | |||
| // TODO: Coming in v2.7 | |||
client.go
Outdated
| // of fields will be updated. Moreover, all entities being upserted must be part | ||
| // of the same partition otherwise the request will be rejected. | ||
| // NOTE: This endpoint is not officially released. No guarantees about correctness | ||
| // or performance of this API will be guaranteed until v2.6 is released. |
There was a problem hiding this comment.
remember to update the comment when release
client.go
Outdated
|
|
||
| results, err := c.connector.MultiUpsert(ctx, re.EntityInfo(), listMultiValues) | ||
| if err != nil { | ||
| return nil, err |
phliar
reviewed
Apr 27, 2018
| @@ -1,6 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## v3.0.0 (unreleased) | |||
| - Implement MultiUpsert method in client and expose it via the Client interface (#304) | |||
There was a problem hiding this comment.
I don't see any breaking changes here, what's the reason for wanting to call this 3.0?
There was a problem hiding this comment.
i guess no reason. should i add a 2.7.0?
change versioning number
jc-fireball
reviewed
Apr 30, 2018
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## v3.0.0 (unreleased) | |||
| ## v2.7.0 (unreleased) | |||
There was a problem hiding this comment.
we intend to release 3.0 as next release
change back to 3.0.0
Change versioning to 3.0
Clarify comments
|
Tiffany Cheng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last of 3 pull requests to complete functionality for multi upsert in the gateway. Multi remove is implemented in all other connectors but this diff does not implement/expose it in the client and defers that until the minor version release following the release of upsert.