Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pinned the Node.js version for development #10867

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RohanTalip
Copy link
Contributor

@RohanTalip RohanTalip commented May 1, 2024

Description of change

This pull request adds 2 files to pin the Node.js version for development:

  • .tool-versions is used by asdf
  • .nvmrc is used by nvm

I chose the same version as the @types/node dev dependency.

My personal preference is to use asdf but I understand that a lot of people use nvm.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting - N/A
  • npm run test passes with this change - N/A
  • This pull request links relevant issues as Fixes #0000 - N/A
  • There are new or updated unit tests validating the change - N/A
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@RohanTalip RohanTalip changed the title Pinned the Node.js version for development chore: pinned the Node.js version for development May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant