-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#11771 attempt a fix for cfreactor flakiness #12150
base: trunk
Are you sure you want to change the base?
Conversation
- remove method swizzling - replace a few 'send's with 'sendall's - add type annotations let's see if any of that helps the CoreFoundation reactor make it through the test suite
The fact that |
OK, same test still flaky. The fact that the reactor always says that it couldn't stop a reactor that is already running suggests that somehow the application's call to I guess I will try to do some print statement debugging in CI to validate this theory. |
dangit fail |
This reverts commit 1f714a8.
…vertently cleared
The failure on try 2 is this
which… coincidentally is on the CF reactor, but seems to be unrelated to the core issue here |
The failure on try 3 is similar:
… still the CF reactor, again, which I don't love. Will investigate but I think it's just a different flake |
Scope and purpose
Fixes #11771