Cleanup astbuilder and add support for nested modules #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the SignatureBuilder and the BaseBuilder classes.
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
+ Coverage 87.26% 87.31% +0.04%
==========================================
Files 22 22
Lines 4264 4279 +15
Branches 840 844 +4
==========================================
+ Hits 3721 3736 +15
Misses 351 351
Partials 192 192
Continue to review full report at Codecov.
|
tristanlatr
changed the title
|
This is probably not needed if we are using pydocspec in the future. |
|
I’m reopening this PR since I believe not everything is to be trashed here, especially the signature builder class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the
SignatureBuilderand theBaseBuilderclasses.This PR does some cleanup in order to generalize part of the ASTBuilder logic such that we can subclass it to build from and to JSON data. See #93.