Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add record_provenance argument to sim_mutations; closes #2272 #2273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petrelharp
Copy link
Contributor

I just followed what's done in ancestry.py here.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (a2d0753) to head (20cc812).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2273   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          20       20           
  Lines       11337    11340    +3     
  Branches     2304     2306    +2     
=======================================
+ Hits        10376    10379    +3     
  Misses        523      523           
  Partials      438      438           
Flag Coverage Δ
C 91.52% <100.00%> (+<0.01%) ⬆️
python 98.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
msprime/mutations.py 97.32% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2d0753...20cc812. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Should we update the changelog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants