Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inputs/outputs to upgrade action #241

Merged
merged 6 commits into from May 14, 2024
Merged

Conversation

TylerJang27
Copy link
Contributor

@TylerJang27 TylerJang27 commented May 10, 2024

Per a user request, adds the following:

  • Input for assignees
  • Input to override the default created branch name
  • Output the PR number and other PR info for consumption from other actions

Verified run

@TylerJang27 TylerJang27 requested review from det and puzzler7 May 13, 2024 17:20
Copy link
Contributor

@puzzler7 puzzler7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -26,6 +26,7 @@ jobs:
private_key: ${{ secrets.TRUNK_OPEN_PR_APP_PRIVATE_KEY }}

- name: Trunk Upgrade
id: upgrade
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert? Assuming you used this for the test run.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving in. Doesn't detract, and makes future debugging easier

@TylerJang27 TylerJang27 merged commit d5b1b61 into main May 14, 2024
37 of 40 checks passed
@TylerJang27 TylerJang27 deleted the tyler/expand-upgrade branch May 14, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants