Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server + client): streaming mutations and queries over HTTP #5700

Merged
merged 91 commits into from
May 19, 2024

Conversation

KATT
Copy link
Member

@KATT KATT commented May 3, 2024

🎯 Changes

  • Replace httpBatchStreamLink with an implementation that also handles async generators and deferred promise
  • Colocate the serializer and deserialize so it's not spread across @trpc/client and @trpc/server
  • it's basically a simplified variant of tupleson that should be easier to fit in with fewer edge-cases

Other stuff / notes

Copy link

github-actions bot commented May 3, 2024

Diagnostics Comparison

Numbers

Metric PR next
Files 798 798 (➖ 0)
Lines of Library 40,640 40,640 (➖ 0)
Lines of Definitions 120,184 120,086 (🔺 98)
Lines of TypeScript 4,967 4,967 (➖ 0)
Lines of JavaScript 0 0 (➖ 0)
Lines of JSON 0 0 (➖ 0)
Lines of Other 0 0 (➖ 0)
Identifiers 175,981 175,837 (🔺 144)
Symbols 109,421 109,350 (🔺 71)
Types 89 89 (➖ 0)
Instantiations 0 0 (➖ 0)
Memory used 174,212 177,313 (🔽🟢 -3,101)
Assignability cache size 0 0 (➖ 0)
Identity cache size 0 0 (➖ 0)
Subtype cache size 0 0 (➖ 0)
Strict subtype cache size 0 0 (➖ 0)

Timings and averages

Metric PR next
max (s) 4.353 4.314 (🔺 0.04)
min (s) 4.353 4.314 (🔺 0.04)
avg (s) 4.353 4.314 (🔺 0.04)
median (s) 4.353 4.314 (🔺 0.04)
length 1 1 (➖ 0)
unstable timings

Unstable

Timings are not reliable in here

Metric PR next
I/O Read time 0.05 0.04 (🔺 0.01)
Parse time 0.7 0.72 (🔽🟢 -0.02)
ResolveTypeReference time 0.03 0.03 (➖ 0)
ResolveModule time 0.11 0.1 (🔺 0.01)
ResolveLibrary time 0.01 0.02 (🔽🟢 -0.01)
Program time 1.02 1.04 (🔽🟢 -0.02)
Bind time 0.42 0.41 (🔺 0.01)
Total time 1.43 1.45 (🔽🟢 -0.02)

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ✅ Ready (Inspect) Visit Preview May 19, 2024 4:08pm
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 4:08pm
trpc-sse ❌ Failed (Inspect) May 19, 2024 4:08pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 4:08pm

KATT and others added 3 commits May 19, 2024 17:54
Copy link

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Streaming Mutations / Queries
3 participants