ariels' version of: Upgrade version of oapi-codegen
#7532
Conversation
|
No linked issues found. Please add the corresponding issues in the pull request description. |
arielshaqed
changed the title
oapi-codegenoapi-codegen
|
Looks like the current failures are due to |
Yeah, I figured those out. Now it's broken because the new codegen the OpenAPI 3.1 interpretation that forbids DELETE with a body. Can I override that setting somehow? |
|
@arielshaqed the reason for the failures was due to the incorrect placement of the template files. It changed a lot since the old 1.5.6 days... Mind the change under the: |
arielshaqed
force-pushed
the
chore/oapi
branch
2 times, most recently
from
a7cb835
to
15f6aab
Compare
|
🎊 PR Preview 9ebd118 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-7532.surge.sh 🕐 Build time: 0.012s
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
To get the latest features and bug fixes, we should bump to the latest version of the library.
Still doesn't compile.
Use the [new names from 0.61.0](https://github.com/getkin/kin-openapi/blob/7aa9f7ee3d530160cd6479d28578a40b290d008f/README.md?plain=1#L325-L326).
Still does not compile: generated type of AbortPresignMultipartUpload method
changed, and it is not clear where to get the body!
```compilation
pkg/api/serve.go:59:35: cannot use controller (variable of type *Controller) as apigen.ServerInterface value in argument to apigen.HandlerFromMuxWithBaseURL: *Controller does not implement apigen.ServerInterface (wrong type for method AbortPresignMultipartUpload)
have AbortPresignMultipartUpload("net/http".ResponseWriter, *"net/http".Request, apigen.AbortPresignMultipartUpload, string, string, string, apigen.AbortPresignMultipartUploadParams)
want AbortPresignMultipartUpload("net/http".ResponseWriter, *"net/http".Request, string, string, string, apigen.AbortPresignMultipartUploadParams)
```
The new Kin generator actually enforces examples are correct. This is a Good Thing.
Apparently Kin now enforces even more OpenAPI rules.
arielshaqed
added
area/API
arielshaqed
added
the
include-changelog
The new generated code no longer aliases some types. This manifests primarily in all pagination parameters, which are now actual strings and ints.
|
This PR is now marked as stale after 30 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label. |
arielshaqed
added
the
no stale
ariels' version of #7493. This one is more for working and linking than it is for pulling!