@uppy/xhr-upload: fix regression for lowercase HTTP methods #5179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff output filesdiff --git a/packages/@uppy/xhr-upload/lib/index.js b/packages/@uppy/xhr-upload/lib/index.js
index 215dbfa..3314979 100644
--- a/packages/@uppy/xhr-upload/lib/index.js
+++ b/packages/@uppy/xhr-upload/lib/index.js
@@ -152,8 +152,12 @@ export default class XHRUpload extends BasePlugin {
_classPrivateFieldLooseBase(this, _getFetcher)[_getFetcher] = files => {
return async (url, options) => {
try {
+ var _options$method;
const res = await fetcher(url, {
...options,
+ method: options == null || (_options$method = options.method) == null
+ ? void 0
+ : _options$method.toUpperCase(),
onTimeout: timeout => {
const seconds = Math.ceil(timeout / 1000);
const error = new Error(this.i18n("uploadStalled", { |
Murderlon
reviewed
May 21, 2024
Murderlon
approved these changes
May 22, 2024
Co-authored-by: Merlijn Vos <merlijn@soverin.net>
|
N.B.: this change won't be included on the |
Merged
github-actions bot
added a commit
that referenced
this pull request
May 23, 2024
| Package | Version | Package | Version | | ----------------- | ------- | ----------------- | ------- | | @uppy/transloadit | 3.6.2 | uppy | 3.25.5 | | @uppy/xhr-upload | 3.6.7 | | | - @uppy/transloadit: do not cancel assembly when removing all files (Merlijn Vos / #5191) - @uppy/xhr-upload: fix regression for lowercase HTTP methods (Antoine du Hamel / #5179) - meta: improve changelog generator (Antoine du Hamel / #5190)
github-actions bot
added a commit
that referenced
this pull request
May 23, 2024
| Package | Version | Package | Version | | ----------------- | ------------ | ----------------- | ------------ | | @uppy/companion | 5.0.0-beta.8 | @uppy/xhr-upload | 4.0.0-beta.5 | | @uppy/transloadit | 4.0.0-beta.6 | uppy | 4.0.0-beta.9 | - @uppy/companion: remove `chalk` from dependencies (Antoine du Hamel / #5178) - @uppy/transloadit: do not cancel assembly when removing all files (Merlijn Vos / #5191) - @uppy/xhr-upload: fix regression for lowercase HTTP methods (Antoine du Hamel / #5179) - meta: improve changelog generator (Antoine du Hamel / #5190)
Murderlon
added a commit
that referenced
this pull request
May 28, 2024
* 4.x: (38 commits) docs: assume tree-shaking bundler is the most common case (#5160) @uppy/core: remove `reason` (#5159) Release: uppy@4.0.0-beta.9 (#5194) Release: uppy@3.25.5 (#5193) @uppy/companion: remove `chalk` from dependencies (#5178) @uppy/transloadit: do not cancel assembly when removing all files (#5191) @uppy/xhr-upload: fix regression for lowercase HTTP methods (#5179) meta: improve changelog generator (#5190) Release: uppy@4.0.0-beta.8 (#5189) examples: add SvelteKit example (#5181) @uppy/companion: fix missing `await` Release: uppy@3.25.4 (#5188) @uppy/svelte: do not attempt removing plugin before it's created (#5186) Update facebook.mdx fixup! @uppy/tus: fix no headers passed to companion if argument is a function (#5182) @uppy/core: resolve some (breaking) TODOs (#4824) @uppy/tus: fix no headers passed to companion if argument is a function (#5182) @uppy/companion: fix google drive gsuite export large size (#5144) @uppy/companion: encode `uploadId` (#5168) @uppy/companion: bump `express-session` (#5177) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might want to revert that in
4.xbranch.Fixes: #5165