Support invalid HTTPRoute status #10714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpollet
added
kind/enhancement
kevinpollet
force-pushed
the
invalid-httproute-status
branch
from
33291d2
to
77b0042
Compare
lbenguigui
requested changes
May 17, 2024
mmatur
approved these changes
May 22, 2024
traefiker
force-pushed
the
invalid-httproute-status
branch
from
930cc74
to
0dea756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request enhances the HTTPRoute status support, by returning an invalid status in some cases.
Note that we have added a hidden Status field in the WRRService configuration to be able to return
500error when something is wrong while loading a BackendRef.Motivation
To enhance the HTTPRoute status support.
Fixes #9158
More
Additional Notes
Co-authored-by: Romain rtribotte@users.noreply.github.com